Daco Harkes
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
89 lines
2.4 KiB
C++
89 lines
2.4 KiB
C++
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "include/bin/dart_io_api.h"
|
|
|
|
#include "bin/crypto.h"
|
|
#include "bin/directory.h"
|
|
#include "bin/eventhandler.h"
|
|
#include "bin/io_natives.h"
|
|
#include "bin/platform.h"
|
|
#include "bin/process.h"
|
|
#if !defined(DART_IO_SECURE_SOCKET_DISABLED)
|
|
#include "bin/secure_socket_filter.h"
|
|
#endif
|
|
#include "bin/thread.h"
|
|
#include "bin/utils.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
void BootstrapDartIo() {
|
|
// Bootstrap 'dart:io' event handler.
|
|
TimerUtils::InitOnce();
|
|
Process::Init();
|
|
#if !defined(DART_IO_SECURE_SOCKET_DISABLED)
|
|
SSLFilter::Init();
|
|
#endif
|
|
EventHandler::Start();
|
|
}
|
|
|
|
void CleanupDartIo() {
|
|
EventHandler::Stop();
|
|
Process::TerminateExitCodeHandler();
|
|
#if !defined(DART_IO_SECURE_SOCKET_DISABLED)
|
|
SSLFilter::Cleanup();
|
|
#endif
|
|
Process::Cleanup();
|
|
}
|
|
|
|
void SetSystemTempDirectory(const char* system_temp) {
|
|
Directory::SetSystemTemp(system_temp);
|
|
}
|
|
|
|
void SetExecutableName(const char* executable_name) {
|
|
Platform::SetExecutableName(executable_name);
|
|
}
|
|
|
|
void SetExecutableArguments(int script_index, char** argv) {
|
|
Platform::SetExecutableArguments(script_index, argv);
|
|
}
|
|
|
|
void GetIOEmbedderInformation(Dart_EmbedderInformation* info) {
|
|
ASSERT(info != nullptr);
|
|
ASSERT(info->version == DART_EMBEDDER_INFORMATION_CURRENT_VERSION);
|
|
|
|
Process::GetRSSInformation(&(info->max_rss), &(info->current_rss));
|
|
}
|
|
|
|
void* OpenFile(const char* name, bool write) {
|
|
return DartUtils::OpenFile(name, write);
|
|
}
|
|
void ReadFile(uint8_t** data, intptr_t* file_len, void* stream) {
|
|
DartUtils::ReadFile(data, file_len, stream);
|
|
}
|
|
void WriteFile(const void* buffer, intptr_t num_bytes, void* stream) {
|
|
DartUtils::WriteFile(buffer, num_bytes, stream);
|
|
}
|
|
void CloseFile(void* stream) {
|
|
DartUtils::CloseFile(stream);
|
|
}
|
|
|
|
bool GetEntropy(uint8_t* buffer, intptr_t length) {
|
|
return Crypto::GetRandomBytes(length, buffer);
|
|
}
|
|
|
|
Dart_NativeFunction LookupIONative(Dart_Handle name,
|
|
int argument_count,
|
|
bool* auto_setup_scope) {
|
|
return IONativeLookup(name, argument_count, auto_setup_scope);
|
|
}
|
|
|
|
const uint8_t* LookupIONativeSymbol(Dart_NativeFunction nf) {
|
|
return IONativeSymbol(nf);
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|