At this point I'm mostly interested in getting your feedback on the
general approach of making the fix processor be table driven. If you
agree that it's a good direction, then I would actually propose adding a
static method to each of the producer classes that looks something like
static AddRequiredKeyword generator() => AddRequiredKeyword();
and updating the map to contain references to those static methods
(rather than local closures), such as:
CompileTimeErrorCode.MISSING_DEFAULT_VALUE_FOR_PARAMETER: const [
AddRequiredKeyword.generator,
],
Doing so would make the code in FixProcessor slightly cleaner, and would
allow the tables to be constants.
Change-Id: Ifdd8a4d82c6ab83aea0929dc9c8a4dcbce271e6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146064
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Brian Wilkerson
0d9c03b6a3