Ryan Macnak
f4e44dd705
When creating a KernelProgramInfo, we create several logical views into the kernel buffer. These are fresh ExternalTypedDatas, rather than proper TypedDataViews, so they do not automically keep the original ExternalTypedData alive. Create an explicit reference to the orginal ExternalTypedData in the KernelProgramInfo. When creating snapshots, this reference is ignored/null'd and the views are turned into copies, effectively dropping the parts of the original buffer that do not have views. Fixes a leak with reload and a use-after-free with eval. Bug: https://github.com/dart-lang/sdk/issues/33973 Bug: https://github.com/dart-lang/sdk/issues/39610 Change-Id: I09d3830133314ccbaa0341d904127c2b6925c4ec Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126825 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
305 lines
10 KiB
C++
305 lines
10 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/compiler/jit/compiler.h"
|
|
#include "platform/assert.h"
|
|
#include "vm/class_finalizer.h"
|
|
#include "vm/code_patcher.h"
|
|
#include "vm/compiler/frontend/bytecode_reader.h"
|
|
#include "vm/dart_api_impl.h"
|
|
#include "vm/heap/safepoint.h"
|
|
#include "vm/kernel_isolate.h"
|
|
#include "vm/object.h"
|
|
#include "vm/symbols.h"
|
|
#include "vm/thread_pool.h"
|
|
#include "vm/unit_test.h"
|
|
|
|
namespace dart {
|
|
|
|
ISOLATE_UNIT_TEST_CASE(CompileFunction) {
|
|
const char* kScriptChars =
|
|
"class A {\n"
|
|
" static foo() { return 42; }\n"
|
|
" static moo() {\n"
|
|
" // A.foo();\n"
|
|
" }\n"
|
|
"}\n";
|
|
Dart_Handle library;
|
|
{
|
|
TransitionVMToNative transition(thread);
|
|
library = TestCase::LoadTestScript(kScriptChars, NULL);
|
|
}
|
|
const Library& lib =
|
|
Library::Handle(Library::RawCast(Api::UnwrapHandle(library)));
|
|
EXPECT(ClassFinalizer::ProcessPendingClasses());
|
|
Class& cls =
|
|
Class::Handle(lib.LookupClass(String::Handle(Symbols::New(thread, "A"))));
|
|
EXPECT(!cls.IsNull());
|
|
String& function_foo_name = String::Handle(String::New("foo"));
|
|
Function& function_foo =
|
|
Function::Handle(cls.LookupStaticFunction(function_foo_name));
|
|
EXPECT(!function_foo.IsNull());
|
|
String& function_source = String::Handle(function_foo.GetSource());
|
|
EXPECT_STREQ("static foo() { return 42; }", function_source.ToCString());
|
|
EXPECT(CompilerTest::TestCompileFunction(function_foo));
|
|
EXPECT(function_foo.HasCode());
|
|
|
|
String& function_moo_name = String::Handle(String::New("moo"));
|
|
Function& function_moo =
|
|
Function::Handle(cls.LookupStaticFunction(function_moo_name));
|
|
EXPECT(!function_moo.IsNull());
|
|
|
|
EXPECT(CompilerTest::TestCompileFunction(function_moo));
|
|
EXPECT(function_moo.HasCode());
|
|
function_source = function_moo.GetSource();
|
|
EXPECT_STREQ("static moo() {\n // A.foo();\n }",
|
|
function_source.ToCString());
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(OptimizeCompileFunctionOnHelperThread) {
|
|
// Create a simple function and compile it without optimization.
|
|
const char* kScriptChars =
|
|
"class A {\n"
|
|
" static foo() { return 42; }\n"
|
|
"}\n";
|
|
Dart_Handle library;
|
|
{
|
|
TransitionVMToNative transition(thread);
|
|
library = TestCase::LoadTestScript(kScriptChars, NULL);
|
|
}
|
|
const Library& lib =
|
|
Library::Handle(Library::RawCast(Api::UnwrapHandle(library)));
|
|
EXPECT(ClassFinalizer::ProcessPendingClasses());
|
|
Class& cls =
|
|
Class::Handle(lib.LookupClass(String::Handle(Symbols::New(thread, "A"))));
|
|
EXPECT(!cls.IsNull());
|
|
String& function_foo_name = String::Handle(String::New("foo"));
|
|
Function& func =
|
|
Function::Handle(cls.LookupStaticFunction(function_foo_name));
|
|
EXPECT(!func.HasCode());
|
|
CompilerTest::TestCompileFunction(func);
|
|
EXPECT(func.HasCode());
|
|
EXPECT(!func.HasOptimizedCode());
|
|
#if !defined(PRODUCT)
|
|
// Constant in product mode.
|
|
FLAG_background_compilation = true;
|
|
#endif
|
|
Isolate* isolate = thread->isolate();
|
|
BackgroundCompiler::Start(isolate);
|
|
isolate->optimizing_background_compiler()->Compile(func);
|
|
Monitor* m = new Monitor();
|
|
{
|
|
MonitorLocker ml(m);
|
|
while (!func.HasOptimizedCode()) {
|
|
ml.WaitWithSafepointCheck(thread, 1);
|
|
}
|
|
}
|
|
delete m;
|
|
BackgroundCompiler::Stop(isolate);
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(CompileFunctionOnHelperThread) {
|
|
// Create a simple function and compile it without optimization.
|
|
const char* kScriptChars =
|
|
"class A {\n"
|
|
" static foo() { return 42; }\n"
|
|
"}\n";
|
|
Dart_Handle library;
|
|
{
|
|
TransitionVMToNative transition(thread);
|
|
library = TestCase::LoadTestScript(kScriptChars, NULL);
|
|
}
|
|
const Library& lib =
|
|
Library::Handle(Library::RawCast(Api::UnwrapHandle(library)));
|
|
EXPECT(ClassFinalizer::ProcessPendingClasses());
|
|
Class& cls =
|
|
Class::Handle(lib.LookupClass(String::Handle(Symbols::New(thread, "A"))));
|
|
EXPECT(!cls.IsNull());
|
|
String& function_foo_name = String::Handle(String::New("foo"));
|
|
Function& func =
|
|
Function::Handle(cls.LookupStaticFunction(function_foo_name));
|
|
EXPECT(!func.HasCode());
|
|
if (!FLAG_enable_interpreter) {
|
|
CompilerTest::TestCompileFunction(func);
|
|
EXPECT(func.HasCode());
|
|
return;
|
|
}
|
|
// Bytecode loading must happen on the main thread. Ensure the bytecode is
|
|
// loaded before asking for an unoptimized compile on a background thread.
|
|
kernel::BytecodeReader::ReadFunctionBytecode(thread, func);
|
|
#if !defined(PRODUCT)
|
|
// Constant in product mode.
|
|
FLAG_background_compilation = true;
|
|
#endif
|
|
Isolate* isolate = thread->isolate();
|
|
BackgroundCompiler::Start(isolate);
|
|
isolate->background_compiler()->Compile(func);
|
|
Monitor* m = new Monitor();
|
|
{
|
|
MonitorLocker ml(m);
|
|
while (!func.HasCode()) {
|
|
ml.WaitWithSafepointCheck(thread, 1);
|
|
}
|
|
}
|
|
delete m;
|
|
BackgroundCompiler::Stop(isolate);
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(RegenerateAllocStubs) {
|
|
const char* kScriptChars =
|
|
"class A {\n"
|
|
"}\n"
|
|
"unOpt() => new A(); \n"
|
|
"optIt() => new A(); \n"
|
|
"A main() {\n"
|
|
" return unOpt();\n"
|
|
"}\n";
|
|
|
|
Class& cls = Class::Handle();
|
|
TransitionVMToNative transition(thread);
|
|
|
|
Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
|
|
Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
|
|
EXPECT_VALID(result);
|
|
|
|
{
|
|
TransitionNativeToVM transition(thread);
|
|
Library& lib_handle =
|
|
Library::Handle(Library::RawCast(Api::UnwrapHandle(lib)));
|
|
cls = lib_handle.LookupClass(String::Handle(Symbols::New(thread, "A")));
|
|
EXPECT(!cls.IsNull());
|
|
}
|
|
|
|
{
|
|
TransitionNativeToVM transition(thread);
|
|
cls.DisableAllocationStub();
|
|
}
|
|
result = Dart_Invoke(lib, NewString("main"), 0, NULL);
|
|
EXPECT_VALID(result);
|
|
|
|
{
|
|
TransitionNativeToVM transition(thread);
|
|
cls.DisableAllocationStub();
|
|
}
|
|
result = Dart_Invoke(lib, NewString("main"), 0, NULL);
|
|
EXPECT_VALID(result);
|
|
|
|
{
|
|
TransitionNativeToVM transition(thread);
|
|
cls.DisableAllocationStub();
|
|
}
|
|
result = Dart_Invoke(lib, NewString("main"), 0, NULL);
|
|
EXPECT_VALID(result);
|
|
}
|
|
|
|
TEST_CASE(EvalExpression) {
|
|
const char* kScriptChars =
|
|
"int ten = 2 * 5; \n"
|
|
"get dot => '.'; \n"
|
|
"class A { \n"
|
|
" var apa = 'Herr Nilsson'; \n"
|
|
" calc(x) => '${x*ten}'; \n"
|
|
"} \n"
|
|
"makeObj() => new A(); \n";
|
|
|
|
Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
|
|
Dart_Handle obj_handle =
|
|
Dart_Invoke(lib, Dart_NewStringFromCString("makeObj"), 0, NULL);
|
|
EXPECT_VALID(obj_handle);
|
|
TransitionNativeToVM transition(thread);
|
|
const Object& obj = Object::Handle(Api::UnwrapHandle(obj_handle));
|
|
EXPECT(!obj.IsNull());
|
|
EXPECT(obj.IsInstance());
|
|
|
|
String& expr_text = String::Handle();
|
|
expr_text = String::New("apa + ' ${calc(10)}' + dot");
|
|
Object& val = Object::Handle();
|
|
const Class& receiver_cls = Class::Handle(obj.clazz());
|
|
|
|
if (!KernelIsolate::IsRunning()) {
|
|
UNREACHABLE();
|
|
} else {
|
|
RawLibrary* raw_library = Library::RawCast(Api::UnwrapHandle(lib));
|
|
Library& lib_handle = Library::ZoneHandle(raw_library);
|
|
|
|
Dart_KernelCompilationResult compilation_result =
|
|
KernelIsolate::CompileExpressionToKernel(
|
|
expr_text.ToCString(), Array::empty_array(), Array::empty_array(),
|
|
String::Handle(lib_handle.url()).ToCString(), "A",
|
|
/* is_static= */ false);
|
|
EXPECT_EQ(Dart_KernelCompilationStatus_Ok, compilation_result.status);
|
|
|
|
const ExternalTypedData& kernel_buffer =
|
|
ExternalTypedData::Handle(ExternalTypedData::NewFinalizeWithFree(
|
|
const_cast<uint8_t*>(compilation_result.kernel),
|
|
compilation_result.kernel_size));
|
|
|
|
val = Instance::Cast(obj).EvaluateCompiledExpression(
|
|
receiver_cls, kernel_buffer, Array::empty_array(), Array::empty_array(),
|
|
TypeArguments::null_type_arguments());
|
|
}
|
|
EXPECT(!val.IsNull());
|
|
EXPECT(!val.IsError());
|
|
EXPECT(val.IsString());
|
|
EXPECT_STREQ("Herr Nilsson 100.", val.ToCString());
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(EvalExpressionWithLazyCompile) {
|
|
{ // Initialize an incremental compiler in DFE mode.
|
|
TransitionVMToNative transition(thread);
|
|
TestCase::LoadTestScript("", NULL);
|
|
}
|
|
Library& lib = Library::Handle(Library::CoreLibrary());
|
|
const String& expression = String::Handle(
|
|
String::New("(){ return (){ return (){ return 3 + 4; }(); }(); }()"));
|
|
Object& val = Object::Handle();
|
|
val = Api::UnwrapHandle(
|
|
TestCase::EvaluateExpression(lib, expression,
|
|
/* param_names= */ Array::empty_array(),
|
|
/* param_values= */ Array::empty_array()));
|
|
|
|
EXPECT(!val.IsNull());
|
|
EXPECT(!val.IsError());
|
|
EXPECT(val.IsInteger());
|
|
EXPECT_EQ(7, Integer::Cast(val).AsInt64Value());
|
|
}
|
|
|
|
ISOLATE_UNIT_TEST_CASE(EvalExpressionExhaustCIDs) {
|
|
{ // Initialize an incremental compiler in DFE mode.
|
|
TransitionVMToNative transition(thread);
|
|
TestCase::LoadTestScript("", NULL);
|
|
}
|
|
Library& lib = Library::Handle(Library::CoreLibrary());
|
|
const String& expression = String::Handle(String::New("3 + 4"));
|
|
Object& val = Object::Handle();
|
|
val = Api::UnwrapHandle(
|
|
TestCase::EvaluateExpression(lib, expression,
|
|
/* param_names= */ Array::empty_array(),
|
|
/* param_values= */ Array::empty_array()));
|
|
|
|
EXPECT(!val.IsNull());
|
|
EXPECT(!val.IsError());
|
|
EXPECT(val.IsInteger());
|
|
EXPECT_EQ(7, Integer::Cast(val).AsInt64Value());
|
|
|
|
intptr_t initial_class_table_size =
|
|
Isolate::Current()->class_table()->NumCids();
|
|
|
|
val = Api::UnwrapHandle(
|
|
TestCase::EvaluateExpression(lib, expression,
|
|
/* param_names= */ Array::empty_array(),
|
|
/* param_values= */ Array::empty_array()));
|
|
EXPECT(!val.IsNull());
|
|
EXPECT(!val.IsError());
|
|
EXPECT(val.IsInteger());
|
|
EXPECT_EQ(7, Integer::Cast(val).AsInt64Value());
|
|
|
|
intptr_t final_class_table_size =
|
|
Isolate::Current()->class_table()->NumCids();
|
|
// Eval should not eat into this non-renewable resource.
|
|
EXPECT_EQ(initial_class_table_size, final_class_table_size);
|
|
}
|
|
|
|
} // namespace dart
|