Martin Kustermann c185945507 [vm/aot] Ensure global object pool is relocated by compactor and reloaded when returning from natives ...

When the compactor moves the global object pool the pointer in Thread
was not updated because it was in a macro list which can only hold
objects inside the read-only VM isolate.

All calls into dart need to populate PP as well as all calls returning
from C++ need to restore PP.  There was a missing case where we return
from natives and don't restore PP (i.e. not normal runtime calls).

This started to be an issue after we started moving old space objects.

Cq-Include-Trybots: luci.dart.try:vm-canary-linux-debug-try, vm-dartkb-linux-debug-x64-try, vm-dartkb-linux-release-x64-try, vm-kernel-asan-linux-release-x64-try, vm-kernel-checked-linux-release-x64-try, vm-kernel-linux-debug-ia32-try, vm-kernel-linux-debug-simdbc64-try, vm-kernel-linux-debug-x64-try, vm-kernel-linux-product-x64-try, vm-kernel-linux-release-ia32-try, vm-kernel-linux-release-simarm-try, vm-kernel-linux-release-simarm64-try, vm-kernel-linux-release-simdbc64-try, vm-kernel-linux-release-x64-try, vm-kernel-optcounter-threshold-linux-release-ia32-try, vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-android-release-arm-try, vm-kernel-precomp-bare-linux-release-simarm-try, vm-kernel-precomp-bare-linux-release-simarm64-try, vm-kernel-precomp-bare-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-product-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-obfuscate-linux-release-x64-try, vm-kernel-precomp-win-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-reload-linux-debug-x64-try, vm-kernel-reload-linux-release-x64-try, vm-kernel-reload-rollback-linux-debug-x64-try, vm-kernel-reload-rollback-linux-release-x64-try, vm-kernel-win-debug-ia32-try, vm-kernel-win-debug-x64-try, vm-kernel-win-product-x64-try, vm-kernel-win-release-ia32-try, vm-kernel-win-release-x64-try
Change-Id: I14776be226431e2c53ae888b3c98a1b8c540c4ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98343
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

2019-03-29 15:13:25 +00:00

..

entrypoints

[vm] Use TFA to remove explicit type-checks (including keyword-covariant parameters).

2019-01-08 08:36:58 +00:00

appjit_bytecode_simple_test_body.dart

[vm] Include bytecode in core-jit and app-jit snapshots

2018-10-08 19:51:10 +00:00

appjit_bytecode_simple_test.dart

[vm] Include bytecode in core-jit and app-jit snapshots

2018-10-08 19:51:10 +00:00

appjit_cha_deopt_test_body.dart

Reapply "[vm] Add tests for determinism of script and AppJIT snapshots."

2018-05-31 17:18:42 +00:00

appjit_cha_deopt_test.dart

[vm/compiler] Do not LICM LoadStaticField for uninitialized fields.

2018-07-30 12:29:35 +00:00

appjit_determinism_test.dart

Reapply "[vm] Add tests for determinism of script and AppJIT snapshots."

2018-05-31 17:18:42 +00:00

appjit_load_static_licm_test_body.dart

[vm/compiler] Do not LICM LoadStaticField for uninitialized fields.

2018-07-30 12:29:35 +00:00

appjit_load_static_licm_test.dart

[vm/compiler] Do not LICM LoadStaticField for uninitialized fields.

2018-07-30 12:29:35 +00:00

bad_snapshot

…

bare_instructions_trampolines_test.dart

[VM/Compiler/AOT] Bare instructions 7: Trampolines for out-of-range calls

2019-01-17 12:32:38 +00:00

byte_array_optimized_test.dart

Move all int literal parsing and checking code together.

2018-09-24 11:17:36 +00:00

byte_array_test.dart

Move all int literal parsing and checking code together.

2018-09-24 11:17:36 +00:00

callee_side_type_checks_test.dart

…

catch_entry_state_test.dart

[vm/compiler] Support materializing unboxed variables when entering catch.

2018-09-14 17:39:12 +00:00

compilation_trace_test.dart

[vm] Test compilation traces, type feedback, reused instructions.

2019-03-13 23:36:06 +00:00

data_uri_import_test.dart

…

data_uri_spawn_test.dart

…

double_materialize_test.dart

…

double_to_smi_test.dart

…

error_messages_in_null_checks_test.dart

[vm/aot] Fix obfuscation.

2018-10-26 13:00:33 +00:00

error_stacktrace_test.dart

…

fuzz3608420507_regression_test.dart

[VM/AOT] Make DartTemplateCall::Selector() work even if there is no ICData

2019-01-29 08:21:52 +00:00

generic_field_invocation_test.dart

[vm] Fix bug with generic invocation of fields.

2018-09-28 09:50:21 +00:00

hello_fuchsia_test.dart

…

hello_world_test.dart

…

inline_stack_frame_test.dart

[vm/aot] Fix obfuscation.

2018-10-26 13:00:33 +00:00

issue32950_test.dart

…

kernel_determinism_test.dart

[test] Check for determinism from the kernel compiler.

2018-11-14 01:30:43 +00:00

licm_and_assert_strengthening_test.dart

[vm] Fix AssertAssignable strengthening sometimes using wrong deopt_id.

2019-03-13 12:13:12 +00:00

null_checks_with_dwarf_stack_traces_test.dart

[vm] Fix null checks when CodeSourceMap is missing

2019-02-25 05:50:14 +00:00

optimized_stacktrace_line_and_column_test.dart

…

optimized_stacktrace_line_test.dart

…

random_walk_fuzzer.dart

…

redirection_type_shuffling_test.dart

Type checking for redirecting factories.

2018-09-19 06:20:20 +00:00

regress29620_test.dart

…

regress29846_test.dart

…

regress30853_test.dart

…

regress32508_test.dart

…

regress32597_2_test.dart

…

regress32597_test.dart

…

regress32619_test.dart

[vm] Disable incorrect widening of smis to int32

2018-10-11 18:13:42 +00:00

regress_33999_test.dart

[vm] Propagate failure to instantiate bogus signature to optimizing compiler.

2018-12-19 21:47:34 +00:00

regress_34755_test.dart

[vm] Handle null receiver at call sites that track type exactness

2018-10-25 17:38:44 +00:00

regress_35481_test.dart

[VM/Compiler] Fix binds replaced with statements.

2019-01-03 13:11:36 +00:00

regress_35887_test.dart

[vm] Fix ThrowErrorSlowPath-derived instructions (e.g. CheckNull) in JIT mode.

2019-02-13 16:39:55 +00:00

regress_flutter16182_test.dart

…

regress_flutter20122_test.dart

[vm/lib] String._identityHashCode should be the same as String.get:hashCode

2018-08-02 11:24:25 +00:00

regress_range_analysis_shift_test.dart

[vm] Fix inference of shifts' RHS in range analysis for nullable SMIs.

2019-01-22 11:44:24 +00:00

reused_instructions_test.dart

[vm] Test compilation traces, type feedback, reused instructions.

2019-03-13 23:36:06 +00:00

shared_snapshot_test.dart

[vm] Test compilation traces, type feedback, reused instructions.

2019-03-13 23:36:06 +00:00

single_target_and_method_extractors_test.dart

…

slow_path_shared_stub_test.dart

[VM/Compiler] Do not use unboxed doubles if target CPU does not support VFP

2019-02-05 09:57:52 +00:00

snapshot_test_helper.dart

[vm] Test compilation traces, type feedback, reused instructions.

2019-03-13 23:36:06 +00:00

snapshot_version_test.dart

[VM] Remove support for option --no-preview-dart-2

2018-09-24 20:38:08 +00:00

spawn_infinite_loop_test.dart

…

spawn_shutdown_test.dart

…

stack_overflow_shared_test.dart

[vm/precomp] Re-land support for slow-path sharing of CheckStackOverflow with status file updates.

2018-06-29 12:32:28 +00:00

trigger_gc_in_native_test.dart

[vm/aot] Ensure global object pool is relocated by compactor and reloaded when returning from natives

2019-03-29 15:13:25 +00:00

truncating_ints_test.dart

Remove all uses of --limit-ints-to-64-bits VM option

2018-06-01 19:32:24 +00:00

type_feedback_test.dart

[vm] Test compilation traces, type feedback, reused instructions.

2019-03-13 23:36:06 +00:00

use_bare_instructions_flag_test.dart

[VM/AOT] Ensure we set flags from snapshot very early in the VM initialization

2019-01-25 10:31:48 +00:00

v8_snapshot_profile_writer_test.dart

Re-land "[vm/aot] Fill in names of properties in snapshot profile."

2018-12-03 19:11:42 +00:00

wrap_around_in_range_analysis_test.dart

…