Daco Harkes
3156c5629d
This CL implements `Finalizable` by means of a CFE transform. The transform is implemented in the existing FFI transform to avoid the overhead of traversing the AST an extra time. The FFI transform slows down ~15-30% on Flutter Gallery. For more info see the design doc. TEST=`dart pkg/vm/test/transformations/ffi_test.dart` Design doc: go/dart-vm-finalizable Bug: https://github.com/dart-lang/sdk/issues/47777 Change-Id: I0bf9dead90a61631b7f215dc19fbaa9e40e63c8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227501 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
Overview
The testcases in this directory and its subdirectory are all compiled in various different configurations designed to test various aspects of Fasta (or more generally, package:front_end).
The configurations are described below.
The source of truth for these configurations is the file pkg/front_end/testing.json.
Dart 1.0 Compilation
- Status file: legacy.status
- Standalone test: pkg/front_end/test/fasta/legacy_test.dart
- Expectation prefix:
.direct.expect - How to update expectations:
./pkg/front_end/tool/fasta testing -DupdateExpectations=true compile/test1 compile/test2 ...
Dart 1.0 Outlines
- Status file: outline.status
- Standalone test: pkg/front_end/test/fasta/outline_test.dart
- Expectation prefix:
.outline.expect - How to update expectations:
./pkg/front_end/tool/fasta testing -DupdateExpectations=true outline/test1 outline/test2 ...
Dart 2.0 (strong mode)
- Status file: strong.status
- Standalone test: pkg/front_end/test/fasta/strong_test.dart
- Expectation prefix:
.strong.expect - How to update expectations:
./pkg/front_end/tool/fasta testing -DupdateExpectations=true -DupdateComments=true strong/test1 strong/test2 ...
Note: strong mode configuration additionally parses comments in the test file and can precisely match internal details of the compiler such as the inferred type of an expression or if a warning was emitted at a given location.