Ömer Sinan Ağacan
332f874bd0
Previously we had started to move core patch files to libraries for better code organization. However moving implementation classes to separate libraries required making the implementation types and internal members public. This has two problems: 1. The members can be accessed by end users via `dynamic`. 2. More importantly, because those public internal members can impact TFA results. We don't care about (1) too much, but (2) is important. So in this CL we make the libraries part of `core` again, while keeping the file structure the same when possible. With implementation files listed as "patches" they can still have their own imports, but hey won't be importing each other as they're all part of the same library. This is the first CL in series that merges `_boxed_int` and `_boxed_double` libraries back to `core`, and `_typed_data` back to `typed_data`. Follow-up CLs will merge the other libraries back to `core`. The conventions for files is: - Files that patch core types are named `..._patch.dart`. - Implementation classes are in separate files. Names of the implementation files is either the implementation class name (e.g. `boxed_double.dart` for `_BoxedDouble`), or when implementing multiple class, name of the library being implemented (e.g. `typed_data.dart`). Following these conventions, `double.dart` is renamed to `double_patch.dart`. Because we lose namespacing for helpers, the helper intrinsics like `double` `_toInt` are moved to class members, as before. One problem in the current CL is that in `libraries.yaml`, when I `include` a target, I can't add more `core` patches to the included target, the patch section overrides the included patches. I don't know if this is a bug yet. If it is, we can refactor `libraries.yaml` after it's fixed. Tested: Changes covered by existing tests. Change-Id: Iba7d81d383deff61aad521000f0ca9cf9276dcfb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319500 Reviewed-by: Aske Simon Christensen <askesc@google.com> Reviewed-by: Joshua Litt <joshualitt@google.com> Commit-Queue: Ömer Ağacan <omersa@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency