Tess Strickland
010523ee4a
Instead of trying to lazily create artificial nodes when needed for
WeakSerializationReference (WSR) targets in all cases, create them
eagerly for targets in reachable WSRs, since those are guaranteed
to be needed.
Those for unreachable WSRs are still lazily created as needed, since the
WSR won't even be accessed by the clustered snapshot writer unless the
unreachable WSR is part of another unreachable object that has an
artificial node created.
This rework avoids some issues seen on upcoming CLs where the artificial
nodes for WSR targets weren't getting correctly generated.
-----
Also extend the v8 snapshot profile writer tests to check the sizes of
the text and data sections in ELF snapshots. That means the v8 snapshot
profile writer tests check up to three different measures, from most
precise to least precise, depending on the output mode:
* If writing an ELF snapshot directly: the sum of the sizes attributed
to the text and data section symbols are checked to be exactly the
same as the sum of the sizes of the objects in the profile.
* If writing an ELF snapshot either directly or via assembly: the sum
of the sizes of the text and data sections are checked to be the same
as the sum of the sizes of the objects in the profile. If using an
assembler that merges text and data sections, then account for the
padding between the sections using an approximate check.
* For all: Check that the size of the snapshot as a whole is
approximately equal to the sum of the sizes of the objects in the
profile, accounting both for possible padding and for the global
header information and non-data/non-text sections like the dynamic
symbol section.
TEST=vm/data{,_2}/v8_snapshot_profile_writer_test
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm64-try
Change-Id: I66e0e7fdb5bb98045621bf516f150a4723e08147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198942
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
2.4 KiB
2.4 KiB
Changelog
0.4.3
- Exported some more of the ELF utilities for use in Dart tests.
0.4.2
- When decoding a stack trace, frames corresponding to the functions with DW_AT_artificial DWARF attribute are now omitted from the symbolized stack traces. This is needed because Dart VM no longer omits invisible functions from binary stack traces in certain cases.
0.4.1
- Exported some ELF utilities in lib/elf.dart for use in Dart tests.
0.4.0
- Stable null safe version of package.
0.4.0-nullsafety
- Unstable null safe version of package.
0.3.8
- Support columns when present in line number programs.
0.3.7
- Added buildId accessor for retrieving GNU build IDs from DWARF files that include them.
0.3.6
- Adjusts RegExp for stack trace header line to be more flexible in what it permits to allow additional information to be added in the Dart VM.
0.3.5
- Use virtual addresses in non-symbolic stack frames as a fallback if we cannot retrieve an appropriate offset from the instructions section otherwise.
0.3.4
-
Decoded Dart calls are now never considered internal, only VM stub calls. This is due to a concurrent change in the Dart VM that no longer prints non-symbolic frames for functions considered invisible, which matches the symbolic frame printer and removes the need for the decoder to guess which frames should be hidden.
This package still works on earlier versions of Dart, so the dependencies have not changed. However, it may print more frame information than expected when decoding stack frames from a Dart VM that does not include this change to non-symbolic stack printing.
0.3.3
- No externally visible changes.
0.3.2
- The
findcommand can now look up addresses given as offsets from static symbols, not just hexadecimal virtual or absolute addresses. - Integer inputs (addresses or offsets) without an '0x' prefix or hexadecimal
digits will now be parsed as decimal unless the
-x/--force_hexadecimalflag is used.
0.3.1
- Uses dynamic symbol information embedded in stack frame lines when available.
0.3.0
- Adds handling of virtual addresses within stub code payloads.
0.2.2
- Finds instruction sections by the dynamic symbols the Dart VM creates instead of assuming there are two text sections.
0.2.1
- Added static method
Dwarf.fromBuffer.
0.2.0
- API and documentation cleanups
0.1.0
- Initial release