Vyacheslav Egorov
1ab083ae48
Following the lead of unboxed calling conventions augment out backend to support passing arguments in registers on ARM, ARM64 and X64. Similar to unboxing the calling convention change only applies to functions which are invoked statically or through global dispatch table. Functions which are invoked from native code or directly invoked by dynamic call sites are not allowed to use register calling convention. This CL avoid messing too much with call instructions and instead leans on adjusting existing machinery: MoveArgument instructions corresponding to register arguments are simply detached from the graph and are processed as input constraints by the register allocator. The computation of the calling convention is centralized in `ComputeCallingConvention` in `flow_graph.cc` and is used by callees and callers. While working on this CL I have also discovered an existing bug in catch move handling (see added test runtime/tests/vm/dart/try_catch_parameter_sync_test.dart). On a large Flutter app this decreases the size of generated code by 1.8% (380Kb) and there a mixed bag of improvements in runing time, e.g. ``` build_bench (Pixel 6a) -3.536% (0.2 noise)423.16 438.68 animation_bench_close_first_frame (Pixel 6a) -3.717% (0.0 noise)253.64 263.43 rrect_contains_bench (Pixel 6a) -3.796% (0.0 noise)0.088700 0.092200 sync_star_sync_star (Pixel 6a) -5.039% (0.0 noise)2.4310 2.5600 sync_star_list (Pixel 6a) -5.329% (0.0 noise)1.0660 1.1260 velocity_tracker_bench (Pixel 6a) -5.731% (0.1 noise)62.039 65.811 sync_star_generated (Pixel 6a) -6.438% (0.0 noise)1.090 01.1650 matrix_utils_transform_point_perspective (Pixel 6a) -6.844% (0.2 noise)0.012520 0.013439 matrix_utils_transform_rect_perspective (Pixel 6a) -7.818% (0.2 noise)0.028117 0.030502 matrix_utils_transform_rect_affine -27.05% (0.7 noise) 0.017494 0.023981 ``` TEST=ci Issue https://github.com/dart-lang/sdk/issues/54955 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-product-x64-try,vm-aot-linux-release-arm64-try,vm-aot-linux-release-simarm_x64-try,vm-aot-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try Change-Id: I9a134a764666a541d4693e6ca9f6813025ecd63e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353404 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
This package hosts VM specific Dart code and helper scripts.