Paul Berry
7ac6ad6d42
Adjusts the logic in the lint `Registry` class so that lint names are matched in case-insensitive fashion. For the most part this is accomplished by adding calls to `.toLowerCase()` inside the `Registry` class, preserving its API. For the `enabled` method, preserving the API would have been a pain (I would have had to translate the keys in the `ruleConfigs` parameter to lower case). So instead I added an assertion to verify that the keys were lower case, and pushed the responsibility to the callers to create lower case keys. This paves the way for a follow-up CL that will translate diagnostic codes to `lower_snake_case` conventions. It also solves a longstanding problem with the mixed case lint rules `no_runtimeType_toString`, `prefer_for_elements_to_map_fromIterable`, `prefer_iterable_whereType`. Previously, the user had to carefully imitate the capitalization of the lint rules when specifying them in the `analysis_options.yaml` file, even though `// ignore:` comments for the lints matched in case insensitive fashion. With this CL, the lint rule names in `analysis_options.yaml` are matched in case insensitive fashion as well. Change-Id: I6a6a6964d83241e49878bbf96ef9b94cbb12098b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465964 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.