Daco Harkes
0295dfc74e
This CL introduces the first combination of `external const factory` with `@patch const factory (.*) = (.*)`. This specific combination was never used in the core libraries, and did not work. Half of the fix is a missing flag from the CFE: https://dart-review.googlesource.com/c/sdk/+/187440 The other half of the fix is matching on the kRedirectingFactoryConstructor tag, and allowing constructor names in procedure targets (even though we never compile those expressions because they are invalid). Bug: https://github.com/dart-lang/sdk/issues/45101 TEST=Using redirecting const factory in patch file in core lib. TEST=tests/ffi(_2)/* Change-Id: I5524bde928290bf32aaea9170eda1f2d03127fa6 Cq-Include-Trybots: luci.dart.try:benchmark-linux-try,front-end-linux-release-x64-try,vm-kernel-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187003 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Clement Skau <cskau@google.com>