Files
sdk/pkg/analysis_server/lib
Paul Berry 7911b6a989 Migration: fix handling of part files.
This CL fixes several minor bugs:

- In info_builder.dart, we were trying to apply SourceInformation from
  the defining library to all its parts.

- In NnbdMigrationTestBase, we were trying to fully migrate each file
  before processing any other files.  We need to prepare each input,
  then process each input, then finalize each input.

- In NodeBuilder, we were failing to send part file sources to
  NullabilityGraph.migrating().  As a result, methods declared in part
  files were being treated as already migrated, so they were getting
  the wrong kinds of nullability nodes.

- In _ProvisionalApiTestBase, we were sometimes visiting parts before
  discovering what libraries they were part of, causing inconsistent
  resolution results.

I'm hoping this will be sufficient to address
https://github.com/dart-lang/sdk/issues/40670.

Change-Id: I07d693b31b6cf64bc6f72126f5ef4792b29e5029
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136521
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-02-20 19:55:18 +00:00
..