Martin Kustermann
ea6fb0a16f
This seems to result in -0.6% compressed main module and a bit less in uncompressed mode. Sometimes we have many fields with lazy initializers of the same type. That led us to emit 1 nullable wasm global for each such field. For example all proto classes have a `static BuilderInfo i_` field. This has led to thousands of `(mut (ref null $BuilderInfo))` wasm globals. Now we use a wasm table for this, which is a O(1) in the binary as they all get `null` by default, saving us all these globals. The downside is that accesses have an extra instruction now, but overall this is a win. The CL also cleans up `globals.dart` by separating the concept of a wasm global and reading/writing to it from the concept of a Dart global - as Dart globals can now be backed by wasm globals or table slots. This CL uses the new capability made possible by the refactoring in [0] - namely to emit element sections which initialize wasm table slots with non-function expressions. [0] https://dart-review.googlesource.com/c/sdk/+/459440 Change-Id: Ie57206dff8c0a57a1df5e48c0808167f822bc4a2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475800 Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.