Lasse R.H. Nielsen 6f1b279922 Fix issue 56806, incorrect ignore on futures. ...

Makes `whenComplete` create a new future with either the result of the
original, or the error of a future returned by the callback.
Until now it was returning the original future, causing it to be chained after
it was completed. That caused issue with `ignore()`.
(Which suggests that there is still something iffy about ignore and chaining.)

Combines `chainCoreFuture{Sync,Async}` into one function with boolean flag.
Most of the code is the same, and they had accidentally drifted apart.

Fixes #56806.

CoreLibraryReviewExempt: Should be simple refactoring.
Tested: Regression test added
Bug: http://dartbug.com/56806
Change-Id: I52751c078a4e26a10e9da0a64460e2c5c7f34ae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387360
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

2024-10-15 13:40:52 +00:00

..

async_await_sync_completer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

async_await_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

async_no_await_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors7_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors8_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors11_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors12_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors13_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors14_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors15_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors16_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors17_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors18_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors19_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors20_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors21_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors22_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors23_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors24_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors25_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors26_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors27_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors28_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

catch_errors.dart

Add onError extension method to Future.

2021-01-21 23:13:56 +00:00

dart2js_uncaught_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

error_stack_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

event_helper.dart

Remove uses of : as default value separator in some tests/ directories.

2022-09-07 14:49:17 +00:00

first_regression_test.dart

…

future_constructor2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_constructor_test.dart

…

future_delayed_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_foreach_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_iterable_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_onerror_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_or_bad_type_test.dart

Migrate corelib and lib tests off @compile-error.

2023-04-20 19:19:01 +00:00

future_or_only_in_async_test.dart

…

future_or_strong_test.dart

…

future_or_type_test.dart

Reland "Tweak expect.dart library."

2024-04-26 15:28:26 +00:00

future_record_extension_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_regression_48493_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_self_complete_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_timeout_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

future_value_chain_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

futures_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

ignore_regress_56806_test.dart

Fix issue 56806, incorrect ignore on futures.

2024-10-15 13:40:52 +00:00

intercept_print1_test.dart

…

intercept_schedule_microtask1_test.dart

…

intercept_schedule_microtask2_test.dart

…

intercept_schedule_microtask3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

intercept_schedule_microtask6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

multiple_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

null_future_zone_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

periodic_timer4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

regress46319_test.dart

[ddc] Add unspecified nullability regression test

2021-06-10 20:18:53 +00:00

regress154963234_strong_test.dart

…

regress154963234_weak_test.dart

…

run_zoned1_test.dart

…

run_zoned4_test.dart

…

run_zoned5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned7_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned8_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

run_zoned9_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

schedule_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

slow_consumer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace01_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace02_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace03_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace04_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace05_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace06_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace07_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace08_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace09_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace10_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace11_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace12_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace13_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace14_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace15_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace16_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace17_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace18_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace19_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace20_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace21_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace22_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace23_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace24_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stack_trace25_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_controller_async_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_controller_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_distinct_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_empty_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_error_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_event_transformed_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_first_where_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_from_futures_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_from_iterable_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_iterator_double_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_iterator_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_join_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_last_where_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_listen_zone_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_multi_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic4_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic5_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic6_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_periodic_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_single_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_single_to_multi_subscriber_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_helper.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_nonzero_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_state_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_subscription_as_future_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_subscription_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_take_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_timeout_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transform_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformation_broadcast_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_from_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_from_handlers_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_transformer_test.dart

…

stream_type_test.dart

…

stream_value_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_view_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

stream_zones_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

syncstar_mixed_iterators_test.dart

[vm] Cleanup old async/async*/sync* implementation from kernel

2022-07-11 18:12:41 +00:00

timer_cancel1_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_cancel2_test.dart

…

timer_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_isActive_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

timer_repeat_test.dart

…

timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

unawaited_error_test.dart

[cfe] Add UnresolvedKind for fine grained unresolved reporting

2021-08-25 09:51:54 +00:00

unawaited_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

uncaught_error_handler_throws_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

wait_for_cancel_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_callback_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_periodic_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_timer2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_create_timer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_debug_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_empty_description2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_empty_description_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_error_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_fork_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_future_schedule_microtask_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_register_callback_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_register_callback_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_root_bind_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_guarded_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_run_unary_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

zone_value_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00