a409a1c07d
This helps to avoid any accidental mispellings, enables find usages, and potentially makes future renames easier. The primary goal is to make future work in https://github.com/dart-lang/sdk/issues/56835 easier. Change-Id: I684630a4d6cb145031de0dabc221f247246ea00c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388042 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Auto-Submit: Parker Lougheed <parlough@gmail.com> Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
95 lines
1.6 KiB
Dart
95 lines
1.6 KiB
Dart
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../rule_test_support.dart';
|
|
|
|
main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(AvoidEmptyElseTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class AvoidEmptyElseTest extends LintRuleTest {
|
|
@override
|
|
String get lintRule => LintNames.avoid_empty_else;
|
|
|
|
test_else_emptyStatement_hasElseIf() async {
|
|
await assertDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else if (x < y)
|
|
print('');
|
|
else ;
|
|
print('');
|
|
}
|
|
''', [
|
|
lint(105, 1),
|
|
]);
|
|
}
|
|
|
|
test_else_emptyStatement_noElseIf() async {
|
|
await assertDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else ;
|
|
print('');
|
|
}
|
|
''', [
|
|
lint(72, 1),
|
|
]);
|
|
}
|
|
|
|
test_else_noEmptyStatement_enclosed() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y) {
|
|
print('');
|
|
} else {
|
|
print('');
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_noEmptyStatement_notEnclosed() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else
|
|
print('');
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_else_noStatement_notEnclosed() async {
|
|
await assertDiagnostics(r'''
|
|
void f() {
|
|
var x = 0;
|
|
var y = 1;
|
|
if (x > y)
|
|
print('');
|
|
else
|
|
}
|
|
''', [
|
|
// No lint
|
|
error(ParserErrorCode.EXPECTED_TOKEN, 67, 4),
|
|
error(ParserErrorCode.MISSING_IDENTIFIER, 72, 1),
|
|
]);
|
|
}
|
|
}
|