Robert Nystrom
732b07a42b
I'm still chasing down a couple of google3 failures, but this is ready for review so that I can get it approved and land it once the last couple of failures are fixed. Here is who I think should review what: athom@ for: - DEPS johnniwinther@ for: - pkg/_fe_analyzer_shared - pkg/front_end - pkg/kernel brianwilkerson@ for: - pkg/analysis_server - pkg/analyzer_plugin - pkg/analyzer_utilities kenzieschmoll@ for: - pkg/dartdev pquitslund@ for: - pkg/linter/lib/src/lint_codes.g.dart If you're not the right person, feel free to summon someone else. Most of the changes here are re-running code generators that auto-format the code they generate. The changes are: Roll in the latest dart_style commit: - DEPS Manually updated these test expectations to expect the new style: - pkg/analysis_server/test/lsp/format_test.dart - pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart - pkg/analysis_server/test/src/domains/flutter/set_property_value_test.dart - pkg/analysis_server/test/src/services/flutter/container_properties_test.dart - pkg/analysis_server/test/src/services/flutter/widget_descriptions_test.dart - pkg/analysis_server/test/src/services/refactoring/convert_selected_formal_parameters_to_named_test.dart - pkg/analysis_server/test/src/services/refactoring/move_selected_formal_parameters_left_test.dart This was auto-generated by something, but I'm not sure why it thinks there is a diff: - pkg/analyzer_plugin/doc/api.html Updated to require a version of dart_style that accepts a language version in DartFormatter(): - pkg/analyzer_plugin/pubspec.yaml Updated to always use the latest language version (and thus new style) when invoking the formatter: - pkg/analyzer_utilities/lib/tools.dart Manually updated the formatting in the code templates so that they matched the formatting expected by the tests, which implicitly format using the latest language version: - pkg/dartdev/lib/src/templates/... The rest are all generated files that are formatted so re-generated using the new style: - pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart - pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart - pkg/analysis_server_client/lib/handler/notification_handler.dart - pkg/analysis_server_client/lib/src/protocol/... - pkg/analysis_server/lib/protocol/protocol_generated.dart - pkg/analysis_server/test/integration/support/integration_test_methods.dart - pkg/analysis_server/test/integration/support/protocol_matchers.dart - pkg/analyzer_plugin/lib/protocol/... - pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart - pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart - pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart - pkg/analyzer/lib/src/dart/error/... - pkg/analyzer/lib/src/error/codes.g.dart - pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart - pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart - pkg/analyzer/lib/src/summary/format.dart - pkg/analyzer/lib/src/wolf/ir/ir.g.dart - pkg/compiler/test/tool/graph_isomorphizer/golden/less_simple/lib_000_1.dart - pkg/compiler/test/tool/graph_isomorphizer/golden/less_simple/lib_001_0.dart - pkg/compiler/test/tool/graph_isomorphizer/golden/less_simple/lib_010_0.dart - pkg/compiler/test/tool/graph_isomorphizer/golden/less_simple/lib_100_0.dart - pkg/compiler/test/tool/graph_isomorphizer/golden/simple/... - pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart - pkg/front_end/lib/src/codes/cfe_codes_generated.dart - pkg/front_end/lib/src/util/parser_ast_helper.dart - pkg/front_end/test/parser_test_listener.dart - pkg/front_end/test/parser_test_parser.dart - pkg/front_end/testcases/... - pkg/kernel/lib/src/coverage.dart generated - pkg/kernel/lib/src/equivalence.dart generated - pkg/linter/lib/src/lint_codes.g.dart Change-Id: Ice0141b763e63b84f54692cd19a442a0719673c6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391263 Commit-Queue: Bob Nystrom <rnystrom@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
Overview
The testcases in this directory and its subdirectory are all compiled in various different configurations designed to test various aspects of Fasta (or more generally, package:front_end).
The configurations are described below.
The source of truth for these configurations is the file pkg/front_end/testing.json.
Updating all expectations
To update test expectations for all tests at once, run:
dart pkg/front_end/tool/update_expectations.dart
Note that this takes a long time and should only be used when many tests need updating.
Updating expectations for a single test
To update the expectations for a specific test, provide the folder and test name as an argument.
For example, if you want to update the test expectations for a test, such as pkg/front_end/testcases/general/abstract_instantiation.dart, then run:
dart pkg/front_end/tool/update_expectations.dart general/abstract_instantiation
Updating expectations for all tests in a folder
If you want to update the test expectations for a specific folder of tests such as the pkg/front_end/testcases/general/ folder, then run:
dart pkg/front_end/tool/update_expectations.dart general/...
Dart 1.0 Outlines
- Status file: outline.status
- Standalone test: pkg/front_end/test/fasta/outline_test.dart
- Expectation prefix:
.outline.expect - How to update expectations:
./pkg/front_end/tool/fasta testing -DupdateExpectations=true outline/test1 outline/test2 ...
Dart 2.0 (strong mode)
- Status file: strong.status
- Standalone test: pkg/front_end/test/fasta/strong_test.dart
- Expectation prefix:
.strong.expect - How to update expectations:
./pkg/front_end/tool/fasta testing -DupdateExpectations=true -DupdateComments=true strong/test1 strong/test2 ...
Note: strong mode configuration additionally parses comments in the test file and can precisely match internal details of the compiler such as the inferred type of an expression or if a warning was emitted at a given location.