Lasse R.H. Nielsen
f8086c81ae
Collects files from `package:async_helper` and `tests/language` that are generally useful, so that all test-related helpers are in `package:expect`. Moves the two libraries from `package:async_helper` into `package:expect`, and the `tests/language/static_type_helper.dart` file too. Deprecates `async_minitest.dart`, to follow `minitest.dart`, expecting the Flutter use of it to have been fixed to not break on deprecation (I believe Flutter no longer breaks builds on deprecations at all). Patch 1 is the actual change. Patch 2+4+8 is changing all existing references to the files. Patch 6 ignores deprecation in files still using `async_minitest.dart`. 3+5+7+9 are updating this text to make the numbers match. Then it's just test-expectations and small tweaks from there. Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
56 lines
1.8 KiB
Dart
56 lines
1.8 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:expect/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
import '../helpers/compiler_helper.dart';
|
|
|
|
const String TEST_ONE = r"""
|
|
foo(a) {
|
|
var myVariableName = a.toString();
|
|
print(myVariableName);
|
|
print(myVariableName);
|
|
}
|
|
""";
|
|
|
|
const String TEST_TWO = r"""
|
|
class A {
|
|
@pragma('dart2js:noElision')
|
|
var length;
|
|
}
|
|
foo(a) {
|
|
print([]); // Make sure the array class is instantiated.
|
|
return A().length + a.length;
|
|
}
|
|
""";
|
|
|
|
main() {
|
|
runTests() async {
|
|
// Check that one-shot interceptors preserve variable names, see
|
|
// https://code.google.com/p/dart/issues/detail?id=8106.
|
|
await compile(TEST_ONE, entry: 'foo', check: (String generated) {
|
|
Expect.isTrue(
|
|
generated.contains(new RegExp(r'[$A-Z]+\.toString\$0\$\(a\)')));
|
|
Expect.isTrue(generated.contains('myVariableName'));
|
|
});
|
|
// Check that an intercepted getter that does not need to be
|
|
// intercepted, is turned into a regular getter call or field
|
|
// access.
|
|
await compile(TEST_TWO, entry: 'foo', check: (String generated) {
|
|
Expect.isFalse(generated.contains(r'a.get$length()'),
|
|
'a.get\$length() not expected in\n$generated');
|
|
Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.A\$\(\)\.length')),
|
|
'.length expected in\n$generated');
|
|
Expect.isTrue(
|
|
generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as\(a\)')),
|
|
'*.get\$length expected in\n$generated');
|
|
});
|
|
}
|
|
|
|
asyncTest(() async {
|
|
print('--test from kernel------------------------------------------------');
|
|
await runTests();
|
|
});
|
|
}
|