Lasse R.H. Nielsen
f8086c81ae
Collects files from `package:async_helper` and `tests/language` that are generally useful, so that all test-related helpers are in `package:expect`. Moves the two libraries from `package:async_helper` into `package:expect`, and the `tests/language/static_type_helper.dart` file too. Deprecates `async_minitest.dart`, to follow `minitest.dart`, expecting the Flutter use of it to have been fixed to not break on deprecation (I believe Flutter no longer breaks builds on deprecations at all). Patch 1 is the actual change. Patch 2+4+8 is changing all existing references to the files. Patch 6 ignores deprecation in files still using `async_minitest.dart`. 3+5+7+9 are updating this text to make the numbers match. Then it's just test-expectations and small tweaks from there. Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
64 lines
1.6 KiB
Dart
64 lines
1.6 KiB
Dart
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import "package:expect/async_helper.dart";
|
|
import "package:expect/expect.dart";
|
|
import '../helpers/compiler_helper.dart';
|
|
|
|
String SHOULD_NOT_BE_BOXED_TEST = r'''
|
|
main() {
|
|
var a;
|
|
for (var i=0; i<10; i++) {
|
|
a = () => i;
|
|
}
|
|
print(a());
|
|
}
|
|
''';
|
|
|
|
String SHOULD_BE_BOXED_TEST = r'''
|
|
run(f) => f();
|
|
main() {
|
|
var a;
|
|
for (var i=0; i<10; run(() => i++)) {
|
|
a = () => i;
|
|
}
|
|
print(a());
|
|
}
|
|
''';
|
|
|
|
String ONLY_UPDATE_LOOP_VAR_TEST = r'''
|
|
run(f) => f();
|
|
main() {
|
|
var a;
|
|
for (var i=0; i<10; run(() => i++)) {
|
|
var b = 3;
|
|
a = () => b = i;
|
|
}
|
|
print(a());
|
|
}
|
|
''';
|
|
|
|
main() {
|
|
runTests() async {
|
|
String generated1 = await compileAll(SHOULD_NOT_BE_BOXED_TEST);
|
|
Expect.isTrue(generated1.contains('main_closure(i)'),
|
|
'for-loop variable should not have been boxed');
|
|
|
|
String generated2 = await compileAll(SHOULD_BE_BOXED_TEST);
|
|
Expect.isFalse(generated2.contains('main_closure(i)'),
|
|
'for-loop variable should have been boxed');
|
|
|
|
String generated3 = await compileAll(ONLY_UPDATE_LOOP_VAR_TEST);
|
|
Expect.isFalse(generated3.contains('main_closure(i)'),
|
|
'for-loop variable should have been boxed');
|
|
Expect.isFalse(generated3.contains(', _box_0.b = 3,'),
|
|
'non for-loop captured variable should not be updated in loop');
|
|
}
|
|
|
|
asyncTest(() async {
|
|
print('--test from kernel------------------------------------------------');
|
|
await runTests();
|
|
});
|
|
}
|