Lasse R.H. Nielsen
f8086c81ae
Collects files from `package:async_helper` and `tests/language` that are generally useful, so that all test-related helpers are in `package:expect`. Moves the two libraries from `package:async_helper` into `package:expect`, and the `tests/language/static_type_helper.dart` file too. Deprecates `async_minitest.dart`, to follow `minitest.dart`, expecting the Flutter use of it to have been fixed to not break on deprecation (I believe Flutter no longer breaks builds on deprecations at all). Patch 1 is the actual change. Patch 2+4+8 is changing all existing references to the files. Patch 6 ignores deprecation in files still using `async_minitest.dart`. 3+5+7+9 are updating this text to make the numbers match. Then it's just test-expectations and small tweaks from there. Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
105 lines
1.8 KiB
Dart
105 lines
1.8 KiB
Dart
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Test that parameters keep their names in the output.
|
|
|
|
import 'dart:async';
|
|
import "package:expect/async_helper.dart";
|
|
import "package:expect/expect.dart";
|
|
import '../helpers/compiler_helper.dart';
|
|
|
|
const String TEST_ONE = r"""
|
|
class A { foo() => 499; }
|
|
class B { bar() => 42; }
|
|
|
|
main() {
|
|
A().foo();
|
|
B().bar();
|
|
}
|
|
""";
|
|
|
|
const String TEST_TWO = r"""
|
|
class A {
|
|
foo() => 499;
|
|
bar() => 42;
|
|
}
|
|
|
|
main() {
|
|
A().foo();
|
|
A().bar();
|
|
}
|
|
""";
|
|
|
|
const String TEST_THREE = r"""
|
|
class A {
|
|
foo() => 499;
|
|
bar() => 42;
|
|
}
|
|
|
|
class B extends A {
|
|
foo() => -499;
|
|
bar() => -42;
|
|
}
|
|
|
|
var y;
|
|
foo(i) {
|
|
if (0 != i) {
|
|
y--;
|
|
foo(i - 1);
|
|
y++;
|
|
}
|
|
}
|
|
|
|
makeStaticInliningHard() {
|
|
y = 0;
|
|
foo(10);
|
|
return 0 == y;
|
|
}
|
|
|
|
|
|
// id returns [x] in a way that should be difficult to predict statically.
|
|
id(x) {
|
|
y = x;
|
|
foo(10);
|
|
return y;
|
|
}
|
|
|
|
main() {
|
|
var a = A();
|
|
var b = B();
|
|
var x = a;
|
|
if (makeStaticInliningHard()) x = b;
|
|
x.foo();
|
|
x.bar();
|
|
}
|
|
""";
|
|
|
|
const String TEST_FOUR = r"""
|
|
class A { foo() => 499; }
|
|
|
|
foo(f) { f(); }
|
|
|
|
main() {
|
|
foo(new A().foo);
|
|
}
|
|
""";
|
|
|
|
main() {
|
|
// At some point Dart2js generated bad object literals with dangling commas:
|
|
// { a: true, }. Make sure this doesn't happen again.
|
|
RegExp danglingComma = RegExp(r',[ \n]*}');
|
|
|
|
Future runTests() async {
|
|
for (String test in [TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR]) {
|
|
String generated = await compileAll(test);
|
|
Expect.isFalse(danglingComma.hasMatch(generated));
|
|
}
|
|
}
|
|
|
|
asyncTest(() async {
|
|
print('--test from kernel------------------------------------------------');
|
|
await runTests();
|
|
});
|
|
}
|