Derek Xu
e7fd092044
This reverts commit46e70a7c07. Reason for revert: New asserts failing in Flutter Engine tests Original change's description: > Reland "[VM/Timeline] Make timestamp1_or_id variables more understandable" > > Relanding without changes because the cbuild failure was unrelated. > > TEST=Checked that duration events still looked correct in traces written > by the Perfetto file recorder. Checked that events still looked correct > in traces recorded to the MacOS recorder. > > This is a reland of commit354e1d22cb> > Original change's description: > > [VM/Timeline] Make timestamp1_or_id variables more understandable > > > > This CL improves documentation, and renames fields/methods to make it > > more understandable that timestamp1 and id are stored in the same field > > of dart::TimelineEvent (because the event types that need to store > > timestamp1 are disjoint from the ones that need to store id). > > > > TEST=Checked that duration events still looked correct in traces written > > by the Perfetto file recorder. Checked that events still looked correct > > in traces recorded to the MacOS recorder. > > > > Change-Id: I25ff1f4c6cc432f035ac2be99fa7f162290ea77f > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/305880 > > Reviewed-by: Ben Konyi <bkonyi@google.com> > > Commit-Queue: Derek Xu <derekx@google.com> > > Change-Id: I28c0c3af9869900cc8bb2b3b416904a231d143e0 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306301 > Reviewed-by: Ben Konyi <bkonyi@google.com> > Commit-Queue: Derek Xu <derekx@google.com> Change-Id: Ia1fe524268c06fd68c689fe048d8cc38a6ed8a23 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306661 Reviewed-by: Ben Konyi <bkonyi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Derek Xu <derekx@google.com>