Konstantin Shcheglov
e730a62688
Expand ScopeContext into the single place that manages resolver name-scope transitions, and migrate visitors to use it directly. ScopeContext now: - Owns the current name scope and handles push/pop via withScope(). - Provides focused helpers for common resolver scopes: - withLocalScope(), withInstanceScope(), withExtensionScope() - withTypeParameterScope() and withTypeParameterList() - withFormalParameterScope() - withConstructorInitializerScope() and withPrimaryParameterScope() - withDocImportScope() for documentation comment resolution - Renames walkMixinDeclarationScopes() to visitMixinDeclaration() and routes mixin traversal through the shared helper. Update ResolutionVisitor, ScopeResolverVisitor, and ReferenceResolver to: - Remove temporary routing getters/methods and ad-hoc try/finally scope management. - Use the new ScopeContext helpers for consistent scoping across declarations, function bodies, and DeCo/primary-constructor-related initializer contexts. - Reduce duplicated scope wiring and keep scope behavior localized for easier future evolution. Change-Id: I753cccc4ed14b4b7c4f34f9c91f5d00895f84c5f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481981 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.