36c57a4101
Make `main` function returns explicit in anticipation of `strict_top_level_inference`. Change-Id: I9fe087478b748594e49a586b033412263fda7920 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412383 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Phil Quitslund <pquitslund@google.com>
338 lines
4.9 KiB
Dart
338 lines
4.9 KiB
Dart
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import '../rule_test_support.dart';
|
|
|
|
void main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(InvalidCasePatternsTestLanguage219);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class InvalidCasePatternsTestLanguage219 extends LintRuleTest
|
|
with LanguageVersion219Mixin {
|
|
@override
|
|
String get lintRule => LintNames.invalid_case_patterns;
|
|
|
|
test_binaryExpression_logicalAnd() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
f(bool b) {
|
|
switch (b) {
|
|
case true && false:
|
|
}
|
|
}
|
|
''',
|
|
[lint(36, 13)],
|
|
);
|
|
}
|
|
|
|
test_binaryExpression_plus() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case 1 + 2:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 5)],
|
|
);
|
|
}
|
|
|
|
test_conditionalExpression() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case true ? 1 : 2:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 12), error(WarningCode.DEAD_CODE, 54, 1)],
|
|
);
|
|
}
|
|
|
|
test_constConstructorCall() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
class C {
|
|
const C();
|
|
}
|
|
|
|
f(C c) {
|
|
switch (c) {
|
|
case C():
|
|
}
|
|
}
|
|
''',
|
|
[lint(59, 3)],
|
|
);
|
|
}
|
|
|
|
test_constConstructorCall_explicitConst_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
class C {
|
|
const C();
|
|
}
|
|
f(C c) {
|
|
switch (c) {
|
|
case const C():
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_identicalCall() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case identical(1, 2):
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 15)],
|
|
);
|
|
}
|
|
|
|
test_isExpression() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case 1 is int:
|
|
}
|
|
}
|
|
''',
|
|
[error(WarningCode.UNNECESSARY_TYPE_CHECK_TRUE, 43, 8), lint(43, 8)],
|
|
);
|
|
}
|
|
|
|
test_isNotExpression() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case 1 is! int:
|
|
}
|
|
}
|
|
''',
|
|
[error(WarningCode.UNNECESSARY_TYPE_CHECK_FALSE, 43, 9), lint(43, 9)],
|
|
);
|
|
}
|
|
|
|
test_lengthCall() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case ''.length:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 9)],
|
|
);
|
|
}
|
|
|
|
test_listLiteral() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case [1, 2]:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 6)],
|
|
);
|
|
}
|
|
|
|
test_listLiteral_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case const [1, 2]:
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_listLiteral_typeArgs() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case <int>[1, 2]:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 11)],
|
|
);
|
|
}
|
|
|
|
test_mapLiteral() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case {'k': 'v'}:
|
|
}
|
|
}
|
|
''',
|
|
[lint(42, 10)],
|
|
);
|
|
}
|
|
|
|
test_mapLiteral_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case const {'k': 'v'}:
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_mapLiteral_parenthesized() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case ({'k': 'v'}):
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 10)],
|
|
);
|
|
}
|
|
|
|
test_mapLiteral_parenthesized_twice() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case (({'k': 'v'})):
|
|
}
|
|
}
|
|
''',
|
|
[lint(44, 10)],
|
|
);
|
|
}
|
|
|
|
test_mapLiteral_typeArgs() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case <String,String>{'k': 'v'}:
|
|
}
|
|
}
|
|
''',
|
|
[lint(42, 25)],
|
|
);
|
|
}
|
|
|
|
test_parenthesizedExpression_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case (1):
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_prefixedExpression_intLiteral_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case -1:
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_setLiteral() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case {1}:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 3)],
|
|
);
|
|
}
|
|
|
|
test_setLiteral_ok() async {
|
|
await assertNoDiagnostics(r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case const {1}:
|
|
}
|
|
}
|
|
''');
|
|
}
|
|
|
|
test_setLiteral_typeArgs() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f(Object o) {
|
|
switch (o) {
|
|
case <int>{1}:
|
|
}
|
|
}
|
|
''',
|
|
[lint(43, 8)],
|
|
);
|
|
}
|
|
|
|
test_unaryOperator_minus() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f() {
|
|
const o = 1;
|
|
switch (1) {
|
|
case -o:
|
|
}
|
|
}
|
|
''',
|
|
[lint(50, 2)],
|
|
);
|
|
}
|
|
|
|
test_unaryOperator_not() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
void f() {
|
|
const b = false;
|
|
switch (true) {
|
|
case !b:
|
|
}
|
|
}
|
|
''',
|
|
[lint(65, 2)],
|
|
);
|
|
}
|
|
|
|
test_wildcard() async {
|
|
await assertDiagnostics(
|
|
r'''
|
|
f(int n) {
|
|
const _ = 3;
|
|
switch (n) {
|
|
case _:
|
|
}
|
|
}
|
|
''',
|
|
[lint(50, 1)],
|
|
);
|
|
}
|
|
}
|