a9469269d7
In AOT this makes reading faster: Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`: ``` msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03) page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71) cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16) instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18) branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35) seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01) seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03) ``` Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`): ``` AstFromBinaryEagerCold: -12.5174% +/- 3.10688% AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433% AstFromBinaryEager: -10.3432% +/- 3.68375% ``` I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway. TEST=Existing tests. Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Morgan :) <davidmorgan@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
112 lines
3.0 KiB
Dart
112 lines
3.0 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:kernel/binary/ast_from_binary.dart';
|
|
import 'package:kernel/kernel.dart';
|
|
import 'package:kernel/src/equivalence.dart';
|
|
|
|
void main(List<String> args) {
|
|
String? resolvedExecutable = Platform.environment['resolvedExecutable'];
|
|
File exe =
|
|
new File(resolvedExecutable ?? Platform.resolvedExecutable).absolute;
|
|
int steps = 0;
|
|
Directory parent = exe.parent.parent;
|
|
while (true) {
|
|
Set<String> foundDirs = {};
|
|
for (FileSystemEntity entry in parent.listSync(recursive: false)) {
|
|
if (entry is Directory) {
|
|
List<String> pathSegments = entry.uri.pathSegments;
|
|
String name = pathSegments[pathSegments.length - 2];
|
|
foundDirs.add(name);
|
|
}
|
|
}
|
|
if (foundDirs.contains("pkg") &&
|
|
foundDirs.contains("tools") &&
|
|
foundDirs.contains("tests")) {
|
|
break;
|
|
}
|
|
steps++;
|
|
if (parent.uri == parent.parent.uri) {
|
|
throw "Reached end without finding the root.";
|
|
}
|
|
parent = parent.parent;
|
|
}
|
|
// We had to go $steps steps to reach the "root" --- now we should go 2 steps
|
|
// shorter to be in the "compiled dir".
|
|
parent = exe.parent;
|
|
for (int i = steps - 2; i >= 0; i--) {
|
|
parent = parent.parent;
|
|
}
|
|
|
|
List<File> dills = [];
|
|
for (FileSystemEntity entry in parent.listSync(recursive: false)) {
|
|
if (entry is File) {
|
|
if (entry.path.toLowerCase().endsWith(".dill")) {
|
|
dills.add(entry);
|
|
}
|
|
}
|
|
}
|
|
Directory sdk = new Directory.fromUri(parent.uri.resolve("dart-sdk/"));
|
|
for (FileSystemEntity entry in sdk.listSync(recursive: true)) {
|
|
if (entry is File) {
|
|
if (entry.path.toLowerCase().endsWith(".dill")) {
|
|
dills.add(entry);
|
|
}
|
|
}
|
|
}
|
|
|
|
print("Found ${dills.length} dills!");
|
|
|
|
List<File> errors = [];
|
|
for (File dill in dills) {
|
|
if (args.isNotEmpty &&
|
|
!args.any((arg) => dill.absolute.path.endsWith(arg))) {
|
|
print('Skipping $dill');
|
|
continue;
|
|
}
|
|
if (!canRead(dill)) {
|
|
errors.add(dill);
|
|
}
|
|
}
|
|
if (errors.isEmpty) {
|
|
print("Read all OK.");
|
|
} else {
|
|
print("Errors when reading:");
|
|
for (File error in errors) {
|
|
print(error);
|
|
}
|
|
exitCode = 1;
|
|
}
|
|
}
|
|
|
|
bool canRead(File dill) {
|
|
print("Reading $dill");
|
|
Uint8List bytes = dill.readAsBytesSync();
|
|
|
|
try {
|
|
Component component1 = new Component();
|
|
new BinaryBuilder(bytes).readComponent(component1);
|
|
|
|
Component component2 = new Component();
|
|
new BinaryBuilder(bytes).readComponent(component2);
|
|
|
|
EquivalenceResult result = checkEquivalence(component1, component2);
|
|
if (!result.isEquivalent) {
|
|
print(result);
|
|
}
|
|
return result.isEquivalent;
|
|
} catch (e, st) {
|
|
print("Error for $dill:");
|
|
print(e);
|
|
print(st);
|
|
print("");
|
|
print("--------------------");
|
|
print("");
|
|
return false;
|
|
}
|
|
}
|