Chloe Stefantsova f749040450 [model] Keep Let expressions intact in the verifier ...

Prior to this CL the CFE verifier would update the type of the
variable in Let expressions from `dynamic` to the computed static type
of the initializer. This CL removes the type update, making the
.expect files reflect the CFE output more accurately. Additionally, a
verification check is added to make sure the static type of the
initializer is assignable to the type of the Let variable.

Change-Id: I0b7b8f175bcb319678c323eb6440d93f1f384a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425500
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>

2025-04-30 03:25:50 -07:00

..

bool_switch.dart

…

bool_switch.dart.strong.expect

…

bool_switch.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

bool_switch.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

bool_switch.dart.strong.transformed.expect

…

bool_switch.dart.textual_outline_modelled.expect

…

bool_switch.dart.textual_outline.expect

…

casts.dart

…

casts.dart.strong.expect

…

casts.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

casts.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

casts.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

casts.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

casts.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

enum_switch.dart

…

enum_switch.dart.strong.expect

[cfe] Create enum elements through SourcePropertyBuilder

2025-01-16 01:17:42 -08:00

enum_switch.dart.strong.modular.expect

[cfe] Create enum elements through SourcePropertyBuilder

2025-01-16 01:17:42 -08:00

enum_switch.dart.strong.outline.expect

[cfe] Create enum elements through SourcePropertyBuilder

2025-01-16 01:17:42 -08:00

enum_switch.dart.strong.transformed.expect

[cfe] Create enum elements through SourcePropertyBuilder

2025-01-16 01:17:42 -08:00

enum_switch.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

enum_switch.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

extension_types.dart

…

extension_types.dart.strong.expect

[cfe] Include Procedure.isSynthetic in ast-to-text

2025-04-10 00:59:49 -07:00

extension_types.dart.strong.modular.expect

[cfe] Include Procedure.isSynthetic in ast-to-text

2025-04-10 00:59:49 -07:00

extension_types.dart.strong.outline.expect

[cfe] Include Procedure.isSynthetic in ast-to-text

2025-04-10 00:59:49 -07:00

extension_types.dart.strong.transformed.expect

[cfe] Include Procedure.isSynthetic in ast-to-text

2025-04-10 00:59:49 -07:00

extension_types.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

extension_types.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

generic_extension_members.dart

…

generic_extension_members.dart.strong.expect

…

generic_extension_members.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

generic_extension_members.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

generic_extension_members.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

generic_extension_members.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

generic_extension_members.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

intersect.dart

…

intersect.dart.strong.expect

…

intersect.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

intersect.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

intersect.dart.strong.transformed.expect

…

intersect.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

intersect.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example0.dart

…

issue2878_example0.dart.strong.expect

…

issue2878_example0.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example0.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example0.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue2878_example0.dart.textual_outline_modelled.expect

…

issue2878_example0.dart.textual_outline.expect

…

issue2878_example1.dart

…

issue2878_example1.dart.strong.expect

…

issue2878_example1.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example1.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example1.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue2878_example1.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example1.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example2.dart

…

issue2878_example2.dart.strong.expect

…

issue2878_example2.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example2.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example2.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue2878_example2.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example2.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example3.dart

…

issue2878_example3.dart.strong.expect

…

issue2878_example3.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example3.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example3.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue2878_example3.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example3.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example4.dart

…

issue2878_example4.dart.strong.expect

…

issue2878_example4.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example4.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue2878_example4.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue2878_example4.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue2878_example4.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

issue51957.dart

…

issue51957.dart.strong.expect

…

issue51957.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue51957.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue51957.dart.strong.transformed.expect

…

issue51957.dart.textual_outline_modelled.expect

…

issue51957.dart.textual_outline.expect

…

issue52041.dart

…

issue52041.dart.strong.expect

…

issue52041.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue52041.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue52041.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue52041.dart.textual_outline_modelled.expect

…

issue52041.dart.textual_outline.expect

…

issue52048.dart

…

issue52048.dart.strong.expect

[cfe] Create synthesized super classes late

2025-02-04 07:08:41 -08:00

issue52048.dart.strong.modular.expect

[cfe] Create synthesized super classes late

2025-02-04 07:08:41 -08:00

issue52048.dart.strong.outline.expect

[cfe] Create synthesized super classes late

2025-02-04 07:08:41 -08:00

issue52048.dart.strong.transformed.expect

[cfe] Create synthesized super classes late

2025-02-04 07:08:41 -08:00

issue52048.dart.textual_outline_modelled.expect

…

issue52048.dart.textual_outline.expect

…

issue54125.dart

…

issue54125.dart.strong.expect

…

issue54125.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue54125.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

issue54125.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

issue54125.dart.textual_outline_modelled.expect

…

issue54125.dart.textual_outline.expect

…

list.dart

…

list.dart.strong.expect

[_fe_analyzer_shared] Return the shortest witness

2025-01-21 00:24:33 -08:00

list.dart.strong.modular.expect

[_fe_analyzer_shared] Return the shortest witness

2025-01-21 00:24:33 -08:00

list.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

list.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

list.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

list.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

not_null.dart

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

not_null.dart.strong.expect

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

not_null.dart.strong.modular.expect

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

not_null.dart.strong.outline.expect

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

not_null.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

not_null.dart.textual_outline_modelled.expect

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

not_null.dart.textual_outline.expect

[cfe] Add test for exhaustiveness of != null

2025-04-10 00:52:31 -07:00

null.dart

…

null.dart.strong.expect

…

null.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

null.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

null.dart.strong.transformed.expect

…

null.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

null.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

nullable_cast.dart

…

nullable_cast.dart.strong.expect

…

nullable_cast.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

nullable_cast.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

nullable_cast.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

nullable_cast.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

nullable_cast.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

object_pattern.dart

…

object_pattern.dart.strong.expect

…

object_pattern.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

object_pattern.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

object_pattern.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

object_pattern.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

object_pattern.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

record.dart

…

record.dart.strong.expect

[_fe_analyzer_shared] Return the shortest witness

2025-01-21 00:24:33 -08:00

record.dart.strong.modular.expect

[_fe_analyzer_shared] Return the shortest witness

2025-01-21 00:24:33 -08:00

record.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

record.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

record.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

record.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

restrictive_cast.dart

…

restrictive_cast.dart.strong.expect

…

restrictive_cast.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

restrictive_cast.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

restrictive_cast.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

restrictive_cast.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

restrictive_cast.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

sealed_cast.dart

…

sealed_cast.dart.strong.expect

…

sealed_cast.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

sealed_cast.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

sealed_cast.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

sealed_cast.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

sealed_cast.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

unsound_cast_3_2.dart

…

unsound_cast_3_2.dart.strong.expect

[cfe] Add Throw.forErrorHandling

2024-02-19 12:12:02 +00:00

unsound_cast_3_2.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

unsound_cast_3_2.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

unsound_cast_3_2.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

unsound_cast_3_2.dart.textual_outline_modelled.expect

Roll the latest dart_style into the SDK.

2024-11-15 08:46:20 +00:00

unsound_cast_3_2.dart.textual_outline.expect

Roll the latest dart_style into the SDK.

2024-11-15 08:46:20 +00:00

unsound_cast.dart

…

unsound_cast.dart.strong.expect

…

unsound_cast.dart.strong.modular.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

unsound_cast.dart.strong.outline.expect

[cfe] Use sound null safety for outline and modular suites

2024-05-15 08:27:25 +00:00

unsound_cast.dart.strong.transformed.expect

[model] Keep Let expressions intact in the verifier

2025-04-30 03:25:50 -07:00

unsound_cast.dart.textual_outline_modelled.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00

unsound_cast.dart.textual_outline.expect

[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

2024-12-05 08:50:30 +00:00