29d5395c49
Make the `HInstruction.sideEffects` field final. The instruction owns the mutable SideEffects objects so it would be dangerous to make the field reference a shared SideEffects object. Update the side effects of an interface call when the target becomes known. We were essentially missing any benefit of inferred side-effects for instance members. Change-Id: I46da1d87e166864cd7fa4cee01f209bcc19986af Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430546 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com>