dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
e2efffa005d565ce2837a575d37b0ca8b422f3cf
sdk/runtime/bin
T
History
Vyacheslav Egorov e2efffa005 [vm] Simplify implementation of native ports 
This reland commit 5a32d8bc7c with a fix
for thread leak (Issue #56717): when `ThreadPool` is shutting down
asynchronously the last worker should detach itself to prevent
leaking associated low-level data structures, because no thread will
join it.

A hang in service isolate shutdown (caused by an existing bug) was fixed by commit 157a0dc7f9.

This CL turns native ports into a thin abstraction over underlying
thread pool instead of building them as full fledged MessageHandler.

This allows to easily implement a variation of native ports which can
handle messages concurrently with the given degree of concurrency.
This type of port can be used to greatly simplify implementation of
IOService - which previously had to do its own concurrency management
on top of "single threaded" native ports. This capability is exposed
as `Dart_NewConcurrentNativePort` API.

The new implementation is in general much cleaner then the old one
with one exception: `Dart_CloseNativePort` API has unfortunate design
where underlying message handler is destroyed asynchronously and
`Dart_CloseNativePort` returns immediately without waiting for pending
tasks to complete. Implementing this on top of `ThreadPool` requires
some changes to thread pool implementation.

Issue https://github.com/dart-lang/sdk/issues/55844

Closes https://github.com/dart-lang/sdk/issues/56717

TEST=ci

Change-Id: Ic68bfb60757685afd75c80a70cdec66cc13c149b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385000
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
2024-09-12 15:16:12 +00:00
..
ffi_test
[vm/ffi] Supporting .address.cast() expression in ffi leaf calls
2024-08-28 06:34:09 +00:00
ffi_unit_test
[vm, ffi] Add Windows ARM64 to FFI unit tests.
2023-10-11 18:41:57 +00:00
abstract_socket_test.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
address_sanitizer.cc
…
analyze_snapshot.cc
[VM] Remove support for --no-sound-null-safety mode
2024-04-05 19:38:12 +00:00
BUILD.gn
Add support for iOS target os
2024-09-03 19:53:58 +00:00
builtin_gen_snapshot.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
builtin_impl_sources.gni
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
builtin_in.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
builtin_natives.cc
[vm/concurrent] Use ffi native resolver for dart:concurrent native functions.
2024-07-26 19:26:11 +00:00
builtin_sources.gni
…
builtin.cc
[vm/shared] Add 'dart:concurrent' core library.
2024-07-10 19:45:29 +00:00
builtin.h
[vm/shared] Add 'dart:concurrent' core library.
2024-07-10 19:45:29 +00:00
cli_sources.gni
…
console_posix.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
console_win.cc
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
console.h
…
crashpad.cc
…
crashpad.h
…
crypto_fuchsia.cc
…
crypto_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
crypto_macos.cc
…
crypto_test.cc
…
crypto_win.cc
…
crypto.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
crypto.h
…
dart_embedder_api_impl.cc
[vm] Remove MSAN_UNPOISONs around print and sort functions.
2024-05-16 16:33:52 +00:00
dart_io_api_impl.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
dart_precompiled_runtime_test_component.cml
[test] Cleanup building Fuchsia packages/components.
2023-10-31 17:11:51 +00:00
dart_test_component.cml
[test] Cleanup building Fuchsia packages/components.
2023-10-31 17:11:51 +00:00
dartdev_isolate.cc
Add 'coverage' flag, defaulting to true, but let the gn application_snapshot default it to false
2024-06-18 09:10:00 +00:00
dartdev_isolate.h
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
dartutils.cc
[vm/shared] Add 'dart:concurrent' core library.
2024-07-10 19:45:29 +00:00
dartutils.h
[vm/shared] Add 'dart:concurrent' core library.
2024-07-10 19:45:29 +00:00
dfe.cc
[ CLI ] Fix snapshot detection logic for google3
2024-06-06 19:10:19 +00:00
dfe.h
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
directory_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
directory_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
directory_macos.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
directory_test.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
directory_win.cc
[io/win] Always use absolute, canonicalized paths.
2024-08-15 17:51:10 +00:00
directory.cc
[vm, io] Don't have pending Dart_TypedDataAcquire during I/O operations.
2024-01-11 23:54:59 +00:00
directory.h
[vm/io] Cleanup long path handling on Windows
2024-03-12 08:29:36 +00:00
elf_loader.cc
[vm/win] Release mappable snapshot once done loading.
2024-04-10 01:41:57 +00:00
elf_loader.h
…
entrypoints_verification_test.cc
…
error_exit.cc
[VM/Runtime] Ensure an isolate exists before calling Dart_ShutdownIsolate()
2023-07-14 01:31:38 +00:00
error_exit.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
eventhandler_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
eventhandler_fuchsia.h
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
eventhandler_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
eventhandler_linux.h
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
eventhandler_macos.cc
[vm/bin] Improve error message in WakeupHandler
2023-05-02 07:32:30 +00:00
eventhandler_macos.h
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
eventhandler_test.cc
Spelling pkg analyzer lib
2023-01-25 14:08:27 +00:00
eventhandler_win.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
eventhandler_win.h
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
eventhandler.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
eventhandler.h
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
exe_utils.cc
[ CLI ] Fix snapshot detection logic for google3
2024-06-06 19:10:19 +00:00
exe_utils.h
[ CLI ] Fix snapshot detection logic for google3
2024-06-06 19:10:19 +00:00
fdutils_fuchsia.cc
…
fdutils_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
fdutils_macos.cc
…
fdutils.h
Spelling runtime bin
2023-01-06 07:48:22 +00:00
file_fuchsia.cc
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
file_linux.cc
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
file_macos.cc
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
file_support.cc
…
file_system_watcher_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
file_system_watcher_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
file_system_watcher_macos.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
file_system_watcher_win.cc
[vm/io,win] Avoid recursive locking in EventHandler
2024-08-06 12:26:19 +00:00
file_system_watcher.cc
[vm/io] Fix memory leak in FileSystemWatcher_InitWatcher
2023-07-04 13:10:42 +00:00
file_system_watcher.h
…
file_test.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
file_win.cc
[io/win] Always use absolute, canonicalized paths.
2024-08-15 17:51:10 +00:00
file_win.h
[io/win] Always use absolute, canonicalized paths.
2024-08-15 17:51:10 +00:00
file.cc
[VM/io] Fix ASAN error (memory leak).
2024-07-30 18:08:46 +00:00
file.h
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
filter.cc
Fix zlib inflation to ignore data past the ADLER32 trailer.
2024-08-20 18:13:33 +00:00
filter.h
Fix zlib inflation to ignore data past the ADLER32 trailer.
2024-08-20 18:13:33 +00:00
gen_snapshot.cc
fix: gen_snapshot crashes if passed a non-existent file.
2024-07-24 21:58:10 +00:00
gzip.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
gzip.h
…
hashmap_test.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
icu.cc
Roll icu to 43953f57b037778a1b8005564afabe214834f7bd.
2024-07-17 16:47:50 +00:00
icu.h
Roll icu to 43953f57b037778a1b8005564afabe214834f7bd.
2024-07-17 16:47:50 +00:00
ifaddrs.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
ifaddrs.h
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
io_buffer.cc
[standalone] Remove tcmalloc.
2023-04-18 20:56:00 +00:00
io_buffer.h
…
io_impl_sources.gni
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
io_natives.cc
Fix zlib inflation to ignore data past the ADLER32 trailer.
2024-08-20 18:13:33 +00:00
io_natives.h
…
io_service_no_ssl.cc
[vm] Simplify implementation of native ports
2024-09-12 15:16:12 +00:00
io_service_no_ssl.h
[io] Align io_service_no_ssl.h with io_service.h.
2024-01-31 19:32:09 +00:00
io_service.cc
[vm] Simplify implementation of native ports
2024-09-12 15:16:12 +00:00
io_service.h
Implement anonymous pipes and the ability to transmit them between processes using Unix Domain Sockets.
2022-09-13 21:16:28 +00:00
io_sources.gni
…
isolate_data.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
isolate_data.h
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
loader.cc
Reland "[vm] Move ResolveUri to bin"
2024-06-26 11:10:06 +00:00
loader.h
…
lockers.h
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
main_impl.cc
Revert "[ CLI ] Don't disable DDS when --disable-dart-dev is provided"
2024-09-12 01:15:27 +00:00
main_impl.h
[vm] Split out main from main.cc
2023-01-16 15:12:38 +00:00
main_options.cc
[ VM ] Exit with error if --disable-dart-dev is provided after a Dart CLI command
2024-08-29 20:40:06 +00:00
main_options.h
[VM/Runtime] - Remove unused sound_null_safety command line option.
2024-06-12 20:51:31 +00:00
main.cc
[vm] Split out main from main.cc
2023-01-16 15:12:38 +00:00
namespace_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
namespace_fuchsia.h
…
namespace_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
namespace_macos.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
namespace_win.cc
[vm/io] Cleanup long path handling on Windows
2024-03-12 08:29:36 +00:00
namespace.cc
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
namespace.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
native_assets_api_impl.cc
Reland "[vm] Move ResolveUri to bin"
2024-06-26 11:10:06 +00:00
native_assets_impl_sources.gni
[vm] Native asset relative path resolution with symlinks
2024-06-12 16:45:19 +00:00
observatory_assets_empty.cc
…
options.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
options.h
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
platform_fuchsia.cc
[vm, io] Restore global destructors for normal shutdown path.
2023-09-05 22:15:58 +00:00
platform_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
platform_macos_cocoa.h
…
platform_macos_cocoa.mm
…
platform_macos.cc
Revert "[vm/mac] Disable setting of the process name as it has side-effects on macos 15+"
2024-08-07 19:28:10 +00:00
platform_macos.h
…
platform_win.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
platform.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
platform.h
[vm, io] Restore global destructors for normal shutdown path.
2023-09-05 22:15:58 +00:00
priority_heap_test.cc
…
process_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
process_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
process_macos.cc
[vm] Remove ProcessStarter on iOS
2023-06-19 00:25:12 +00:00
process_test.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
process_win.cc
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
process.cc
[vm, io] Restore global destructors for normal shutdown path.
2023-09-05 22:15:58 +00:00
process.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
reference_counting.h
[vm] Enable clang-tidy for arm, arm64, riscv64, product, release, precompiler.
2023-07-11 15:13:58 +00:00
root_certificates_unsupported.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
run_vm_tests_test_component.cml
[test] Cleanup building Fuchsia packages/components.
2023-10-31 17:11:51 +00:00
run_vm_tests.cc
[ VM / DDS ] Add --print-dtd-uri flag and launch DTD from the correct snapshot for AOT
2024-03-21 19:50:46 +00:00
secure_socket_filter.cc
[ssl/mac] Avoid unnecessary allocations of x509 certificates, fix leak.
2023-08-11 16:28:46 +00:00
secure_socket_filter.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
secure_socket_unsupported.cc
Support setting the minimum acceptable TLS version.
2024-07-01 21:00:00 +00:00
secure_socket_utils_test.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
secure_socket_utils.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
secure_socket_utils.h
[vm] Fix memory leak freeing boringssl stack types.
2024-01-31 19:24:29 +00:00
security_context_fuchsia.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
security_context_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
security_context_macos.cc
[vm] Remove macOS 10.14 and iOS 12 availability checks
2024-01-25 08:23:51 +00:00
security_context_win.cc
[ssl/win] Always free the X509 certificates after use, fix leak.
2023-12-11 17:49:58 +00:00
security_context.cc
Support setting the minimum acceptable TLS version.
2024-07-01 21:00:00 +00:00
security_context.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
snapshot_empty.cc
…
snapshot_in.cc
…
snapshot_utils_test.cc
[vm/test] Remove checked-in binaries from MachO test.
2022-08-17 16:18:35 +00:00
snapshot_utils.cc
[standalone] Remove dead VM sections from blob container format.
2024-05-31 21:12:28 +00:00
snapshot_utils.h
[standalone] Remove dead VM sections from blob container format.
2024-05-31 21:12:28 +00:00
socket_base_fuchsia.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
socket_base_fuchsia.h
…
socket_base_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
socket_base_linux.h
…
socket_base_macos.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
socket_base_macos.h
…
socket_base_posix.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
socket_base_win.cc
[vm/io,win] Remove Handle::EnsureInitialized
2024-08-06 12:26:19 +00:00
socket_base_win.h
…
socket_base.cc
Add missing include for errno.h
2023-06-09 08:29:30 +00:00
socket_base.h
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
socket_fuchsia.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
socket_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
socket_macos.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
socket_win.cc
[vm/io,win] Cleanup socket accept logic
2024-08-06 12:26:19 +00:00
socket.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
socket.h
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
stdio_fuchsia.cc
[io] Don't restore terminal state on exit.
2022-05-31 15:36:33 +00:00
stdio_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
stdio_macos.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
stdio_win.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
stdio.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
stdio.h
[io] Don't restore terminal state on exit.
2022-05-31 15:36:33 +00:00
sync_socket_fuchsia.cc
…
sync_socket_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
sync_socket_macos.cc
…
sync_socket_win.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
sync_socket.cc
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
sync_socket.h
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
test_utils.cc
[vm] Update to constexpr in runtime/bin.
2023-04-12 20:32:29 +00:00
test_utils.h
MacOS-Signable Compiled Dart Scripts
2022-03-09 18:02:34 +00:00
thread_absl.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
thread_fuchsia.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
thread_linux.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
thread_macos.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
thread_win.cc
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
thread.h
[vm] Move synchronization primitives to platform
2024-08-07 12:59:35 +00:00
typed_data_utils.cc
[vm/io] Null-terminate scope-copied CStrings.
2024-01-26 22:08:37 +00:00
typed_data_utils.h
…
uri_test.cc
Reland "[vm] Move ResolveUri to bin"
2024-06-26 11:10:06 +00:00
uri.cc
Reland "[vm] Move ResolveUri to bin"
2024-06-26 11:10:06 +00:00
uri.h
Reland "[vm] Move ResolveUri to bin"
2024-06-26 11:10:06 +00:00
utils_fuchsia.cc
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
utils_linux.cc
[vm] Remove bin/*_android{.cc,.h} and use Linux implementations.
2024-02-09 14:10:49 +00:00
utils_macos.cc
[vm] Run clang-format on code base
2024-04-17 19:14:41 +00:00
utils_win.cc
[vm/io] Cleanup long path handling on Windows
2024-03-12 08:29:36 +00:00
utils_win.h
[vm] Hoist CStringUniquePtr out of Utils, add CAllocUniquePtr` to simplify code
2024-05-29 10:16:28 +00:00
utils.cc
…
utils.h
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
virtual_memory_fuchsia.cc
…
virtual_memory_posix.cc
[vm] Fix running under WSL 1
2024-01-11 22:24:44 +00:00
virtual_memory_win.cc
…
virtual_memory.h
[vm] Update NULL to nullptr in runtime/bin.
2023-04-12 01:11:05 +00:00
vmservice_impl.cc
[ VM / DDS ] Add --print-dtd-uri flag and launch DTD from the correct snapshot for AOT
2024-03-21 19:50:46 +00:00
vmservice_impl.h
[ VM / DDS ] Add --print-dtd-uri flag and launch DTD from the correct snapshot for AOT
2024-03-21 19:50:46 +00:00