Lasse R.H. Nielsen
f8086c81ae
Collects files from `package:async_helper` and `tests/language` that are generally useful, so that all test-related helpers are in `package:expect`. Moves the two libraries from `package:async_helper` into `package:expect`, and the `tests/language/static_type_helper.dart` file too. Deprecates `async_minitest.dart`, to follow `minitest.dart`, expecting the Flutter use of it to have been fixed to not break on deprecation (I believe Flutter no longer breaks builds on deprecations at all). Patch 1 is the actual change. Patch 2+4+8 is changing all existing references to the files. Patch 6 ignores deprecation in files still using `async_minitest.dart`. 3+5+7+9 are updating this text to make the numbers match. Then it's just test-expectations and small tweaks from there. Change-Id: I1b665135b5fef9b9a0c3b340ffe9daf874d0174c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373120 Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
104 lines
3.0 KiB
Dart
104 lines
3.0 KiB
Dart
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:expect/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
import 'package:expect/config.dart';
|
|
|
|
final invalidObjects = [true, 1, 1.2, 'a'];
|
|
|
|
main() async {
|
|
testFinalizerAttachDetachArgumentValidation();
|
|
|
|
// This test doesn't work reliably on the web yet as it's hard to trigger GC
|
|
// that will run finalizer and weak reference processing.
|
|
if (isVmConfiguration) {
|
|
asyncStart();
|
|
await testFinalizerInvocation();
|
|
asyncEnd();
|
|
}
|
|
}
|
|
|
|
void testFinalizerAttachDetachArgumentValidation() {
|
|
final finalizer = Finalizer<Foo?>((Foo? foo) {});
|
|
final foo = Foo();
|
|
|
|
// Tests invalid arguments.
|
|
for (final invalid in invalidObjects) {
|
|
// Test invalid targets.
|
|
Expect.throws(() => finalizer.attach(invalid, foo));
|
|
Expect.throws(() => finalizer.attach(invalid, null));
|
|
Expect.throws(() => finalizer.attach(invalid, foo, detach: foo));
|
|
Expect.throws(() => finalizer.attach(invalid, null, detach: null));
|
|
|
|
// Test invalid detach tokens.
|
|
Expect.throws(() => finalizer.attach(foo, foo, detach: invalid));
|
|
Expect.throws(() => finalizer.attach(foo, null, detach: invalid));
|
|
|
|
Expect.throws(() => finalizer.detach(invalid));
|
|
}
|
|
|
|
final target = Foo();
|
|
|
|
// Should not cause errors to attach
|
|
finalizer.attach(target, foo);
|
|
finalizer.attach(target, null);
|
|
finalizer.attach(target, foo, detach: target);
|
|
|
|
// Can detach with arbitrary (valid) objects.
|
|
finalizer.detach(target);
|
|
finalizer.detach(foo);
|
|
finalizer.detach({});
|
|
}
|
|
|
|
Future testFinalizerInvocation() async {
|
|
final invokedPeers = <Foo>{};
|
|
final expectedPeersInvoked = <Foo>{};
|
|
final finalizer = Finalizer<Foo>((Foo peer) {
|
|
invokedPeers.add(peer);
|
|
asyncEnd();
|
|
});
|
|
{
|
|
for (int i = 0; i < 10; ++i) {
|
|
final peer = Foo();
|
|
finalizer.attach(Foo(), peer, detach: peer);
|
|
if (i % 3 == 0) {
|
|
finalizer.detach(peer);
|
|
} else {
|
|
asyncStart();
|
|
expectedPeersInvoked.add(peer);
|
|
}
|
|
}
|
|
}
|
|
asyncStart();
|
|
while (invokedPeers.length < expectedPeersInvoked.length) {
|
|
produceGarbage();
|
|
await Future.delayed(const Duration(milliseconds: 10));
|
|
}
|
|
finalizer.detach(Foo()); // Dummy use of [finalizer] to ensure it's not GCed.
|
|
for (final peer in expectedPeersInvoked) {
|
|
Expect.isTrue(invokedPeers.contains(peer));
|
|
}
|
|
asyncEnd();
|
|
}
|
|
|
|
void produceGarbage() {
|
|
const approximateWordSize = 4;
|
|
|
|
List<dynamic> sink = [];
|
|
for (int i = 0; i < 500; ++i) {
|
|
final filler = i % 2 == 0 ? 1 : sink;
|
|
if (i % 250 == 1) {
|
|
// 2 x 25 MB in old space.
|
|
sink = List.filled(25 * 1024 * 1024 ~/ approximateWordSize, filler);
|
|
} else {
|
|
// 498 x 50 KB in new space
|
|
sink = List.filled(50 * 1024 ~/ approximateWordSize, filler);
|
|
}
|
|
}
|
|
print(sink.hashCode); // Ensure there's real use of the allocation.
|
|
}
|
|
|
|
class Foo {}
|