Jens Johansen
20428509df
Analyzer plugin warnings and lints can be ignored with
"// Ignore: plugin_name/lint_name".
Plugins are just packages and packages can start with an underscore,
so the ignore syntax should support that too, which it did not.
This CL changes that so it's supported.
It furthermore changes the extraction method (`ignoredElements`) from
sync* to be a regular sync method because it's so much easier to step
through. It's also faster though:
Below I've run this:
```dart
Stopwatch stopwatch = Stopwatch()..start();
CommentToken token = CommentToken(
TokenType.STRING,
// One of these:
// "",
// "// Ignore: foobar, baz",
42,
);
for (int i = 0; i < 10000000; i++) {
// ignoredElements1 or ignoredElements2 -- sync* vs sync.
var list = token.ignoredElements2.toList();
// One of these:
// if (list.isNotEmpty) throw "Not empty.";
// if (list.length != 2) throw "Not right size.";
}
print("Done in ${stopwatch.elapsed}");
```
as aot-compiled, run each 10 times and put the output through `ministat`:
Empty (''), sync* vs sync:
```
Difference at 95.0% confidence
-0.629713 +/- 0.0755153
-69.6007% +/- 8.34653%
(Student's t, pooled s = 0.08037)
```
2 ignores ('// Ignore: foobar, baz'), sync* vs sync:
```
Difference at 95.0% confidence
-1.17368 +/- 0.0544388
-46.8828% +/- 2.17457%
(Student's t, pooled s = 0.0579385)
```
Change-Id: I0c1abdc8001125e32bb5bddd579a187476f2fe31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449700
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.