Jens Johansen
211ad9acb1
This CL removes async markers where await wasn't used. In a few cases this also meant the ability to make the procedure not return a future at all. Also - at least on the VM with my benchmark run on my PC - returning new Future.value(whatever) in a non-async procedure is faster than returning whatever in an async procedure. TEST=CI and existing tests. Change-Id: I4ba888313c87de76bb0ca02c19eb1ab45f168a85 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213480 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
The frontend_server package is used by both the flutter command line tool and the frontend_server_client package (used by webdev and package:test).
API Stability
Changes to the command line API or behavior should be tested against the follwing test suites (in addition to normal HHH testing):
- flutter_tools: https://github.com/flutter/flutter/tree/master/packages/flutter_tools
- frontend_server_client: https://github.com/dart-lang/webdev/tree/master/frontend_server_client
Otherwise these changes will need to be carefully coordinated with the flutter tooling and frontend_server_client teams.
This API stability does not cover any of the source code APIs.
Stable subset
- The frontend_server kernel compilation and expression evaluation for kernel should be considered "stable".
- The frontend_server JavaScript compilation is semi-stable, but clients should anticipate coordinated breaking changes in the future.
- The frontend_server JavaScript expression evaluation is experimental and is expected to change significantly from Dec 2020 through the end of 2021.
- Specific flags like the --flutter-widget-cache may be added for experimentation and should not be considered stable.