eb1ce5d640
These were found using the unnecessary-null-checks lint. It has a bug that prevents us from enabling it at the moment, but we should consider enabling it once the bug has been fixed. Change-Id: Ice250b5a6a8723c5f08dec5b07ae738e17c842cc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196550 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
138 lines
5.1 KiB
Dart
138 lines
5.1 KiB
Dart
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analysis_server/protocol/protocol.dart';
|
|
import 'package:analysis_server/protocol/protocol_constants.dart';
|
|
import 'package:analysis_server/protocol/protocol_generated.dart';
|
|
import 'package:analysis_server/src/analysis_server.dart';
|
|
import 'package:analysis_server/src/server/crash_reporting_attachments.dart';
|
|
import 'package:analysis_server/src/server/error_notifier.dart';
|
|
import 'package:analysis_server/src/socket_server.dart';
|
|
import 'package:analysis_server/src/utilities/mocks.dart';
|
|
import 'package:analyzer/src/generated/engine.dart';
|
|
import 'package:analyzer/src/generated/sdk.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
void main() {
|
|
group('SocketServer', () {
|
|
test('createAnalysisServer_successful',
|
|
SocketServerTest.createAnalysisServer_successful);
|
|
test('createAnalysisServer_alreadyStarted',
|
|
SocketServerTest.createAnalysisServer_alreadyStarted);
|
|
test('requestHandler_exception', SocketServerTest.requestHandler_exception);
|
|
test('requestHandler_futureException',
|
|
SocketServerTest.requestHandler_futureException);
|
|
});
|
|
}
|
|
|
|
class SocketServerTest {
|
|
static void createAnalysisServer_alreadyStarted() {
|
|
var channel1 = MockServerChannel();
|
|
var channel2 = MockServerChannel();
|
|
var server = _createSocketServer(channel1);
|
|
expect(
|
|
channel1.notificationsReceived[0].event, SERVER_NOTIFICATION_CONNECTED);
|
|
server.createAnalysisServer(channel2);
|
|
channel1.expectMsgCount(notificationCount: 1);
|
|
channel2.expectMsgCount(responseCount: 1);
|
|
expect(channel2.responsesReceived[0].id, equals(''));
|
|
expect(channel2.responsesReceived[0].error, isNotNull);
|
|
expect(channel2.responsesReceived[0].error!.code,
|
|
equals(RequestErrorCode.SERVER_ALREADY_STARTED));
|
|
channel2
|
|
.sendRequest(ServerShutdownParams().toRequest('0'))
|
|
.then((Response response) {
|
|
expect(response.id, equals('0'));
|
|
var error = response.error!;
|
|
expect(error.code, equals(RequestErrorCode.SERVER_ALREADY_STARTED));
|
|
channel2.expectMsgCount(responseCount: 2);
|
|
});
|
|
}
|
|
|
|
static Future createAnalysisServer_successful() {
|
|
var channel = MockServerChannel();
|
|
_createSocketServer(channel);
|
|
channel.expectMsgCount(notificationCount: 1);
|
|
expect(
|
|
channel.notificationsReceived[0].event, SERVER_NOTIFICATION_CONNECTED);
|
|
return channel
|
|
.sendRequest(ServerShutdownParams().toRequest('0'))
|
|
.then((Response response) {
|
|
expect(response.id, equals('0'));
|
|
expect(response.error, isNull);
|
|
channel.expectMsgCount(responseCount: 1, notificationCount: 1);
|
|
});
|
|
}
|
|
|
|
static Future requestHandler_exception() {
|
|
var channel = MockServerChannel();
|
|
var server = _createSocketServer(channel);
|
|
channel.expectMsgCount(notificationCount: 1);
|
|
expect(
|
|
channel.notificationsReceived[0].event, SERVER_NOTIFICATION_CONNECTED);
|
|
var handler = _MockRequestHandler(false);
|
|
server.analysisServer!.handlers = [handler];
|
|
var request = ServerGetVersionParams().toRequest('0');
|
|
return channel.sendRequest(request).then((Response response) {
|
|
expect(response.id, equals('0'));
|
|
var error = response.error!;
|
|
expect(error.code, equals(RequestErrorCode.SERVER_ERROR));
|
|
expect(error.message, equals('mock request exception'));
|
|
expect(error.stackTrace, isNotNull);
|
|
expect(error.stackTrace, isNotEmpty);
|
|
channel.expectMsgCount(responseCount: 1, notificationCount: 1);
|
|
});
|
|
}
|
|
|
|
static Future requestHandler_futureException() async {
|
|
var channel = MockServerChannel();
|
|
var server = _createSocketServer(channel);
|
|
var handler = _MockRequestHandler(true);
|
|
server.analysisServer!.handlers = [handler];
|
|
var request = ServerGetVersionParams().toRequest('0');
|
|
var response = await channel.sendRequest(request, throwOnError: false);
|
|
expect(response.id, equals('0'));
|
|
expect(response.error, isNull);
|
|
channel.expectMsgCount(responseCount: 1, notificationCount: 2);
|
|
expect(channel.notificationsReceived[1].event, SERVER_NOTIFICATION_ERROR);
|
|
}
|
|
|
|
static SocketServer _createSocketServer(MockServerChannel channel) {
|
|
final errorNotifier = ErrorNotifier();
|
|
final server = SocketServer(
|
|
AnalysisServerOptions(),
|
|
DartSdkManager(''),
|
|
CrashReportingAttachmentsBuilder.empty,
|
|
errorNotifier,
|
|
null,
|
|
null,
|
|
null);
|
|
|
|
server.createAnalysisServer(channel);
|
|
errorNotifier.server = server.analysisServer;
|
|
AnalysisEngine.instance.instrumentationService = errorNotifier;
|
|
|
|
return server;
|
|
}
|
|
}
|
|
|
|
class _MockRequestHandler implements RequestHandler {
|
|
final bool futureException;
|
|
|
|
_MockRequestHandler(this.futureException);
|
|
|
|
@override
|
|
Response handleRequest(Request request) {
|
|
if (futureException) {
|
|
Future(throwException);
|
|
return Response(request.id);
|
|
}
|
|
throw 'mock request exception';
|
|
}
|
|
|
|
void throwException() {
|
|
throw 'mock future exception';
|
|
}
|
|
}
|