Brian Wilkerson
df2e8fedbb
This is the first of multiple smaller CLs to refactor `ElementMatcher`. I was starting to fix a bug and realized that the current implementation allows the number of components to be out of sync with the element kind. The primary goal is to prevent that by eventually merging the methods `_componentsForNode` and `_kindsForNode` into a single method (`buildMatchersForNode`). In the process I realized that we can sometimes match either a top-level declaraation or an instance member from a superclass, and that means that we need multiple matchers (otherwise I think the number of components will continue to be out-of-sync with the element kinds). This CL also includes the failing test that started the whole investigation into refactoring this class. Change-Id: I0c3a56f29f0f6c6d0cad6ac80145b26201931518 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228722 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency