zra@google.com
816bf5af2e
On arm64, in Dart code, R18(SP) is the stack pointer. In C++ code, R31(CSP) is the stack pointer. The profiler must choose the right one when performing its bounds checks. This change also fixes a bug in the InvokeDartCode stub on arm64 so that CSP is set to the Isolate's stack limit immediately, rather than a bit later. When it was set a bit later, if a profiler interrupt came in in the interim, the stack would be smashed. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//583683002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40502 260f80e4-7a28-3924-810f-c04153c831b5
117 lines
3.5 KiB
C++
117 lines
3.5 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/globals.h"
|
|
#if defined(TARGET_OS_WINDOWS)
|
|
|
|
#include "vm/flags.h"
|
|
#include "vm/os.h"
|
|
#include "vm/thread_interrupter.h"
|
|
|
|
namespace dart {
|
|
|
|
DECLARE_FLAG(bool, thread_interrupter);
|
|
DECLARE_FLAG(bool, trace_thread_interrupter);
|
|
|
|
#define kThreadError -1
|
|
|
|
class ThreadInterrupterWin : public AllStatic {
|
|
public:
|
|
static bool GrabRegisters(HANDLE handle, InterruptedThreadState* state) {
|
|
CONTEXT context;
|
|
memset(&context, 0, sizeof(context));
|
|
#if defined(TARGET_ARCH_IA32)
|
|
// On IA32, CONTEXT_CONTROL includes Eip, Ebp, and Esp.
|
|
context.ContextFlags = CONTEXT_CONTROL;
|
|
#elif defined(TARGET_ARCH_X64)
|
|
// On X64, CONTEXT_CONTROL includes Rip and Rsp. Rbp is classified
|
|
// as an "integer" register.
|
|
context.ContextFlags = CONTEXT_CONTROL | CONTEXT_INTEGER;
|
|
#else
|
|
UNIMPLEMENTED();
|
|
#endif
|
|
if (GetThreadContext(handle, &context) != 0) {
|
|
#if defined(TARGET_ARCH_IA32)
|
|
state->pc = static_cast<uintptr_t>(context.Eip);
|
|
state->fp = static_cast<uintptr_t>(context.Ebp);
|
|
state->csp = static_cast<uintptr_t>(context.Esp);
|
|
state->dsp = static_cast<uintptr_t>(context.Esp);
|
|
#elif defined(TARGET_ARCH_X64)
|
|
state->pc = static_cast<uintptr_t>(context.Rip);
|
|
state->fp = static_cast<uintptr_t>(context.Rbp);
|
|
state->csp = static_cast<uintptr_t>(context.Rsp);
|
|
state->dsp = static_cast<uintptr_t>(context.Rsp);
|
|
#else
|
|
UNIMPLEMENTED();
|
|
#endif
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
|
|
static void Interrupt(InterruptableThreadState* state) {
|
|
ASSERT(!Thread::Compare(GetCurrentThreadId(), state->id));
|
|
HANDLE handle = OpenThread(THREAD_GET_CONTEXT |
|
|
THREAD_QUERY_INFORMATION |
|
|
THREAD_SUSPEND_RESUME,
|
|
false,
|
|
state->id);
|
|
ASSERT(handle != NULL);
|
|
DWORD result = SuspendThread(handle);
|
|
if (result == kThreadError) {
|
|
if (FLAG_trace_thread_interrupter) {
|
|
OS::Print("ThreadInterrupted failed to suspend thread %p\n",
|
|
reinterpret_cast<void*>(state->id));
|
|
}
|
|
CloseHandle(handle);
|
|
return;
|
|
}
|
|
InterruptedThreadState its;
|
|
its.tid = state->id;
|
|
if (!GrabRegisters(handle, &its)) {
|
|
// Failed to get thread registers.
|
|
ResumeThread(handle);
|
|
if (FLAG_trace_thread_interrupter) {
|
|
OS::Print("ThreadInterrupted failed to get registers for %p\n",
|
|
reinterpret_cast<void*>(state->id));
|
|
}
|
|
CloseHandle(handle);
|
|
return;
|
|
}
|
|
if (state->callback == NULL) {
|
|
// No callback registered.
|
|
ResumeThread(handle);
|
|
CloseHandle(handle);
|
|
return;
|
|
}
|
|
state->callback(its, state->data);
|
|
ResumeThread(handle);
|
|
CloseHandle(handle);
|
|
}
|
|
};
|
|
|
|
|
|
void ThreadInterrupter::InterruptThread(InterruptableThreadState* state) {
|
|
if (FLAG_trace_thread_interrupter) {
|
|
OS::Print("ThreadInterrupter suspending %p\n",
|
|
reinterpret_cast<void*>(state->id));
|
|
}
|
|
ThreadInterrupterWin::Interrupt(state);
|
|
if (FLAG_trace_thread_interrupter) {
|
|
OS::Print("ThreadInterrupter resuming %p\n",
|
|
reinterpret_cast<void*>(state->id));
|
|
}
|
|
}
|
|
|
|
|
|
void ThreadInterrupter::InstallSignalHandler() {
|
|
// Nothing to do on Windows.
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined(TARGET_OS_WINDOWS)
|
|
|