Danny Tuppeny dac58febd0 [analysis_server] Don't use window/showMessageRequest unless client has explicitly expressed support ...

LSP currently has no capability for showMessageRequest and assumed all clients support it. They do not.

Until there's a capability (and clients have been updated to pass it), we should assume there is _not_ support for this. So that it can be used in VS Code, we accept a custom flag in experimental that indicates support for this (which the current VS Code extension is passing).

When there is an official capability we should treat either as an indication of this being supported, and then further into the future we can drop the custom flag.

See https://github.com/microsoft/language-server-protocol/issues/1635.

Change-Id: I7ca36555a5a10231f754faf6ae0ba199f791be35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280173
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

2023-02-01 19:11:06 +00:00

..

lsp_protocol

[analysis_server] Refactor LSP code actions handling

2022-11-23 19:50:58 +00:00

plugin

Spelling build

2023-01-23 08:56:14 +00:00

protocol

Spelling pkg dev compiler

2023-01-26 09:12:41 +00:00

src

[analysis_server] Don't use window/showMessageRequest unless client has explicitly expressed support

2023-02-01 19:11:06 +00:00

starter.dart

…