Bob Nystrom
650c9dcc8e
Without strong mode, a "good enough" implementation is to simply call the generic method with "dynamic" for the type arguments, which is what this does. That should be enough to unblock our internal users. We also need to not report a compile error when dart_internal/extract_type_arguments.dart imports the hidden "dart:_internal" library. This patch does both of those for the VM and dart2js (using its old front end). Note that the test still fails because the test is more particular than most actual user code would be -- it validates that the instantiated type arguments are *exactly* correct, and not that the returned object is merely subtype compatible. Bug: Change-Id: I0343beace4991861b29712b3fd7067ec8dc8f8ba Reviewed-on: https://dart-review.googlesource.com/28020 Commit-Queue: Bob Nystrom <rnystrom@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Régis Crelier <regis@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
115 lines
3.5 KiB
Dart
115 lines
3.5 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
/// Note: the VM concatenates all patch files into a single patch file. This
|
|
/// file is the first patch in "dart:_internal" which contains all the imports
|
|
/// used by patches of that library. We plan to change this when we have a
|
|
/// shared front end and simply use parts.
|
|
|
|
import "dart:core" hide Symbol;
|
|
|
|
import "dart:typed_data" show Int32List;
|
|
|
|
/// These are the additional parts of this patch library:
|
|
// part "class_id_fasta.dart";
|
|
// part "print_patch.dart";
|
|
// part "symbol_patch.dart";
|
|
|
|
@patch
|
|
List<T> makeListFixedLength<T>(List<T> growableList)
|
|
native "Internal_makeListFixedLength";
|
|
|
|
@patch
|
|
List<T> makeFixedListUnmodifiable<T>(List<T> fixedLengthList)
|
|
native "Internal_makeFixedListUnmodifiable";
|
|
|
|
@patch
|
|
Object extractTypeArguments<T>(T instance, Function extract) {
|
|
// TODO(31371): Implement this correctly for Dart 2.0.
|
|
// In Dart 1.0, instantiating the generic with dynamic (which this does),
|
|
// gives you an object that can be used anywhere a more specific type is
|
|
// expected, so this works for now.
|
|
return extract();
|
|
}
|
|
|
|
class VMLibraryHooks {
|
|
// Example: "dart:isolate _Timer._factory"
|
|
static var timerFactory;
|
|
|
|
// Example: "dart:io _EventHandler._sendData"
|
|
static var eventHandlerSendData;
|
|
|
|
// A nullary closure that answers the current clock value in milliseconds.
|
|
// Example: "dart:io _EventHandler._timerMillisecondClock"
|
|
static var timerMillisecondClock;
|
|
|
|
// Implementation of Resource.readAsBytes.
|
|
static var resourceReadAsBytes;
|
|
|
|
// Implementation of package root/map provision.
|
|
static var packageRootString;
|
|
static var packageConfigString;
|
|
static var packageRootUriFuture;
|
|
static var packageConfigUriFuture;
|
|
static var resolvePackageUriFuture;
|
|
|
|
static var _computeScriptUri;
|
|
static var _cachedScript;
|
|
static set platformScript(var f) {
|
|
_computeScriptUri = f;
|
|
_cachedScript = null;
|
|
}
|
|
|
|
static get platformScript {
|
|
if (_cachedScript == null && _computeScriptUri != null) {
|
|
_cachedScript = _computeScriptUri();
|
|
}
|
|
return _cachedScript;
|
|
}
|
|
}
|
|
|
|
final bool is64Bit = _inquireIs64Bit();
|
|
|
|
bool _inquireIs64Bit() native "Internal_inquireIs64Bit";
|
|
|
|
bool _classRangeCheck(int cid, int lowerLimit, int upperLimit) {
|
|
return cid >= lowerLimit && cid <= upperLimit;
|
|
}
|
|
|
|
bool _classRangeCheckNegative(int cid, int lowerLimit, int upperLimit) {
|
|
return cid < lowerLimit || cid > upperLimit;
|
|
}
|
|
|
|
// Utility class now only used by the VM.
|
|
class Lists {
|
|
static void copy(List src, int srcStart, List dst, int dstStart, int count) {
|
|
if (srcStart < dstStart) {
|
|
for (int i = srcStart + count - 1, j = dstStart + count - 1;
|
|
i >= srcStart;
|
|
i--, j--) {
|
|
dst[j] = src[i];
|
|
}
|
|
} else {
|
|
for (int i = srcStart, j = dstStart; i < srcStart + count; i++, j++) {
|
|
dst[j] = src[i];
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Prepend the parent type arguments (maybe null) to the function type
|
|
// arguments (may be null). The result is null if both input vectors are null
|
|
// or is a newly allocated and canonicalized vector of length 'len'.
|
|
_prependTypeArguments(functionTypeArguments, parentTypeArguments, len)
|
|
native "Internal_prependTypeArguments";
|
|
|
|
// Called by IRRegExpMacroAssembler::GrowStack.
|
|
Int32List _growRegExpStack(Int32List stack) {
|
|
final newStack = new Int32List(stack.length * 2);
|
|
for (int i = 0; i < stack.length; i++) {
|
|
newStack[i] = stack[i];
|
|
}
|
|
return newStack;
|
|
}
|