Ömer Sinan Ağacan
da4bf60a09
- Imported things (modules, globals, tables, functions) don't need to declared before defining things, as we don't assign indices to things before finalizing the IR, and when finalizing we assign ids to imported things before defined things, in `finalizeImportsAndBuilders`. Remove documentation saying imports should be declared before definitions. `FunctionsBuilder._functions` list was used in the name section, and required imports to come before definitions. This list is now removed, instead we pass `[...imported, ...defined]` to the names section. - Stop upcasting imported things to `Import` before we need to upcast. - Fix global lists passed to `NameSection`. These lists need to include imports as well (even though we never name them, wasm_builder doesn't allow naming them yet) otherwise the indices in the name section will be incorrect. wasm_builder doesn't allow importing types yet, so we don't need to do the same for the types list. Change-Id: Id05632c3af7937bd66d7581d89d538137020f6e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366601 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency