Vyacheslav Egorov
14f7622ef4
Android is based on Linux, so most of the files were identical sans some subtle discrepancies caused by drift over time. This discrepancies were making code base harder to maintain and in fact were hiding bugs. For example, on Android eventhandler's implementation of timers which relied on passing timeout to `epoll_wait` contained a bug which was not present on Linux which used `timerfd` instead. TEST=ci and manual testing of Flutter app on Android device Fixes https://github.com/dart-lang/sdk/issues/54868 Cq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-product-arm-try,vm-ffi-android-product-arm64c-try,vm-ffi-android-release-arm-try,vm-ffi-android-release-arm64c-try Bug: b/311165013 Change-Id: Ia166f69c14177ec34160805a0983eafee8ea65f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350923 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
45 lines
1.2 KiB
C++
45 lines
1.2 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "platform/globals.h"
|
|
#if defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_ANDROID)
|
|
|
|
#include <errno.h> // NOLINT
|
|
#include <fcntl.h> // NOLINT
|
|
|
|
#include "bin/crypto.h"
|
|
#include "bin/fdutils.h"
|
|
#include "platform/signal_blocker.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
bool Crypto::GetRandomBytes(intptr_t count, uint8_t* buffer) {
|
|
ThreadSignalBlocker signal_blocker(SIGPROF);
|
|
intptr_t fd = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
|
|
open("/dev/urandom", O_RDONLY | O_CLOEXEC));
|
|
if (fd < 0) {
|
|
return false;
|
|
}
|
|
intptr_t bytes_read = 0;
|
|
do {
|
|
int res = TEMP_FAILURE_RETRY_NO_SIGNAL_BLOCKER(
|
|
read(fd, buffer + bytes_read, count - bytes_read));
|
|
if (res < 0) {
|
|
int err = errno;
|
|
close(fd);
|
|
errno = err;
|
|
return false;
|
|
}
|
|
bytes_read += res;
|
|
} while (bytes_read < count);
|
|
close(fd);
|
|
return true;
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|
|
|
|
#endif // defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_ANDROID)
|