Sam Rawlins
ee69f45a1f
Work towards #60635 In this change, we rework the AnalysisErrorListener deprecation to better support users who have their own class that implements AnalysisErrorListener. This change introduces a sealed supertype, DiagnosticOrErrorListener, with the old implementation, AnalysisErrorListener, and the new implementation, DiagnosticListener, as its sole direct subclasses. Users who have implemented AnalysisErrorListener should be able to instead implement DiagnosticListener, and their class is an acceptable instance of DiagnosticOrErrorListener, wherever that is needed. In a breaking change we can drop AnalysisErrorListener and deprecate DiagnosticOrErrorListener, and in the next breaking change, we can drop DiagnosticOrErrorListener. For reference, see the first API difference when deprecating AnalysisErrorListener and introducing DiagnosticListener: https://github.com/dart-lang/sdk/commit/903d77cc8229972a424941dcb7b7b79741e833eb#diff-dec15868961d7eadcd009f49d129bebcdb747aaa8dbfde5f5a08884e0cf11e32 Change-Id: I3ccf11d54b41fbca98d020d89978d250c16b4c04 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436480 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.