Daco Harkes
d27f166b75
This CL enables tree shaking of `Struct` sub classes by simulating the native behavior in Dart code. We call the struct constructors in let expressions where FFI trampolines are created which allocate these struct objects in native code. This way TFA is instructed about the native behavior. The VM recognizes these constructor calls as dead code and removes them. For more info see go/dart-ffi-struct-treeshaking. Closes: https://github.com/dart-lang/sdk/issues/38721 This CL fixes the types on the generated #fromTypedDataBase constructors. Also, this CL also cleans up the struct naming: * _addressOf -> _typedDataBase * _fromPointer -> _fromTypedDataBase * #pointer -> #typedDataBase These cleanups are not split into a separate CL to prevent updating the .expect files multiple times. Finally, this CL enables running a single transformer test through: `dart pkg/vm/test/transformations/type_flow/transformer_test.dart name` TEST=pkg/vm/testcases/transformations/type_flow/transformer/ffi_struct_constructors.dart TEST=tests/ffi(_2)/function_callbacks_structs_by_value_generated_test.dart TEST=tests/ffi(_2)/function_structs_by_value_generated_test.dart Change-Id: I418d0d73bc86b234dfe5b7b04ae726c33d2b8aeb Cq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,dart-sdk-linux-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193661 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency