Files

T

Alexander Markov 6c9a830fda [vm/compiler] Ensure that write barriers are not eliminated across LoadField which can call initializer directly

Write barriers should not be eliminated for a StoreInstanceField
if there is a Dart call between store and object allocation.
This is implemented using Instruction::CanCallDart()
predicate, which is overridden for TemplateDartCall.

However, LoadField instructions for late fields with initializers can
also call initializer function directly without entering runtime.

This change introduces LoadFieldInstr::CanCallDart() to avoid
incorrect write barrier elimination across such LoadField instructions.

TEST=vm/cc/IRTest_WriteBarrierElimination_LoadLateField

Bug: b/204355807
Change-Id: Ibd9fe61e9723f1f4ecc9e4f5cedc3024d9d03c75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218583
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>

2021-10-29 16:48:13 +00:00

aot

Reapply "[vm] Streamline Zones."

2021-10-14 00:10:12 +00:00

api

[vm] Add feature to connect AOT code to code comments via .debug_line

2021-02-02 11:35:00 +00:00

assembler

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

backend

[vm/compiler] Ensure that write barriers are not eliminated across LoadField which can call initializer directly

2021-10-29 16:48:13 +00:00

ffi

[vm/ffi] Add Bool

2021-10-18 10:44:11 +00:00

frontend

[vm] Fix TypedClosureCall test in PRODUCT

2021-10-29 11:38:41 +00:00

jit

[vm] Background compile one function per task.

2021-10-28 17:53:08 +00:00

asm_intrinsifier_arm64.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

asm_intrinsifier_arm.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

asm_intrinsifier_ia32.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

asm_intrinsifier_test.cc

[vm] Lower smi value used for setting identity hash codes

2021-06-04 17:40:57 +00:00

asm_intrinsifier_x64.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

asm_intrinsifier.cc

…

asm_intrinsifier.h

[vm] Move implementation of dart:math intrinsics to flow graph builder

2021-08-27 17:42:27 +00:00

call_specializer.cc

[vm] Faster double.floor()/ceil()/truncate() in AOT mode (x64, arm64)

2021-09-07 19:52:04 +00:00

call_specializer.h

[vm] Faster double.floorToDouble/ceilToDouble/truncateToDouble/roundToDouble in AOT mode

2021-08-27 00:33:46 +00:00

cha_test.cc

[vm/concurrency] Change references to class_table/object_store/heap from Isolate to IsolateGroup

2021-01-06 15:22:11 +00:00

cha.cc

[vm] Clean up changes around internal-only class ids.

2021-08-13 20:00:41 +00:00

cha.h

…

compiler_pass.cc

[vm/compiler] Add --print-precompiler-timings

2021-05-11 11:15:53 +00:00

compiler_pass.h

[vm/compiler] Add --print-precompiler-timings

2021-05-11 11:15:53 +00:00

compiler_sources.gni

[vm] Move implementation of dart:math intrinsics to flow graph builder

2021-08-27 17:42:27 +00:00

compiler_state.cc

[vm/compiler] Remove StringInterpolate instruction

2021-07-01 12:57:32 +00:00

compiler_state.h

[vm/compiler] Remove StringInterpolate instruction

2021-07-01 12:57:32 +00:00

compiler_timings.cc

[vm/compiler] Add --print-precompiler-timings

2021-05-11 11:15:53 +00:00

compiler_timings.h

[vm/compiler] Minor improvements for AOT compilation time

2021-09-13 21:25:30 +00:00

graph_intrinsifier.cc

[vm] Move implementation of dart:math intrinsics to flow graph builder

2021-08-27 17:42:27 +00:00

graph_intrinsifier.h

[vm] Move implementation of dart:math intrinsics to flow graph builder

2021-08-27 17:42:27 +00:00

intrinsifier.cc

[vm] Move implementation of dart:math intrinsics to flow graph builder

2021-08-27 17:42:27 +00:00

intrinsifier.h

…

method_recognizer.cc

[VM] Adds native field accessor in Dart.

2021-07-28 08:31:17 +00:00

method_recognizer.h

…

offsets_extractor.cc

[vm] Faster double.floor()/ceil()/truncate() in AOT mode (x64, arm64)

2021-09-07 19:52:04 +00:00

README.md

…

recognized_methods_list.h

Use interpolation in print and writeAll

2021-09-29 02:45:32 +00:00

relocation_test.cc

[vm] Fix gcc build.

2021-06-17 16:05:02 +00:00

relocation.cc

[vm/compiler] Improve precision of AOT code relocator

2021-04-29 15:12:15 +00:00

relocation.h

[vm/compiler] Improve precision of AOT code relocator

2021-04-29 15:12:15 +00:00

runtime_api.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

runtime_api.h

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

runtime_offsets_extracted.h

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

runtime_offsets_list.h

Reland "[vm/compiler] Add more checks in TTSes for uninstantiated types."

2021-09-27 10:57:18 +00:00

stub_code_compiler_arm64.cc

[vm, compiler] Fix FFI callbacks on ARM64C.

2021-09-22 17:11:36 +00:00

stub_code_compiler_arm.cc

[vm, compiler] Adjust the write barrier stub to no longer assume there is no race when setting the remembered bit.

2021-09-22 00:16:58 +00:00

stub_code_compiler_ia32.cc

[vm, compiler] Adjust the write barrier stub to no longer assume there is no race when setting the remembered bit.

2021-09-22 00:16:58 +00:00

stub_code_compiler_x64.cc

[vm, compiler] Adjust the write barrier stub to no longer assume there is no race when setting the remembered bit.

2021-09-22 00:16:58 +00:00

stub_code_compiler.cc

[vm] Store type class id for Types as ClassIdTagType, not Smi.

2021-10-20 16:31:02 +00:00

stub_code_compiler.h

[vm, compiler] Fix FFI callbacks on ARM64C.

2021-09-22 17:11:36 +00:00

write_barrier_elimination_test.cc

[vm/compiler] Ensure that write barriers are not eliminated across LoadField which can call initializer directly

2021-10-29 16:48:13 +00:00

write_barrier_elimination.cc

[vm] Standardize hashing instance methods in C++.

2021-04-14 10:04:48 +00:00

write_barrier_elimination.h

…

README.md

Dart VM Compilation Pipeline

This folder contains Dart VM compilation pipeline.

Compilation pipeline is mainly responsible for converting AST or Kernel AST into IL flow graphs and then generating native code from IL.

It has the following structure:

Directory	What goes there
`assembler/`	Assemblers and disassemblers
`backend/`	IL based compilation backend: optimization passes and architecture specific code generation rules
`frontend/`	Frontends responsible for converting AST into IL
`jit/`	JIT specific passes and compilation pipeline entry points
`aot/`	AOT specific passes and compilation pipeline entry points
`.`	Shared code or code without clear designation.

Currently there are no layering restrictions and components from different subfolders can reference each other.