Sigmund Cherem
d19a405abb
We will be deprecating the dart2js script shipped with the sdk under dart-sdk/bin/. This change starts using 'dart compile js' when running dart2js in `useSdk` mode. For host-asserts, we continue to use a helper script that invokes dart2js from sources. We will continue to support this helper script, but it will become an internal only tool. It is a bit confusing that such script lives under sdk/bin/dart2js and sdk/bin/dart2js_developer. We may consider renaming this in a later CL or moving it to a new location (e.g. under tools). Change-Id: I4f426936f5e0e0a1a7854f4f555198d5ae382079 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229060 Reviewed-by: Alexander Thomas <athom@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency