Paul Berry
a226405a70
This change updates the mini_ast testing infrastructure so that: - It properly models the "exception type" part of a catch clause (the type named after the `on` keyword). - It requires an exception variable to be specified if there is a stack trace variable (this is required by the Dart grammar). - It requires an exception type to be specified if there is no exception variable (this is required by the Dart grammar). - During the "pre-visit" stage, the exception variable and stack trace variable are registered with the `AssignedVariables` object, so that they can be properly handled by type promotion. - During the main "visit" stage, the exception variable and stack trace variable are assigned the appropriate types. Flow analysis unit tests are updated in order to meet the new requirements, and flow analysis tests are added to check that stack trace and exception variables are promotable and appropriately typed. By ensuring that stack trace and exception variables are properly typed during flow analysis tests, this paves the way for some follow-up work, in which I plan to re-work how flow analysis keeps track of variable types. There is no behavioral change to the analyzer or compiler pipeline; these changes are confined to `pkg/_fe_analyzer_shared/test`. Change-Id: I49c4b894d82d1dc58d62e3d3f25d232c9106922e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434145 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.