Jens Johansen
c9ebb0e311
When the VM has an `int` it often represents it as a `_Smi` (which extends `_IntegerImplementation` which implements `int`), but the interface member for e.g. `+` on `_Smi` is `_IntegerImplementation.+` and `_IntegerImplementation` is not special-cased in `isSpecialCasedBinaryOperator` (but `int` and `num` is, so using `int` having the interface member `num.+` makes `isSpecialCasedBinaryOperator` return true if the type is `int` but false if the type is `_Smi`). Not knowing which specialized types the VM could send for more general types that are then specialized in the compiler this CL fixes the issue (linked below) by using the static types of definitions from `dart:`. Fixes https://github.com/dart-lang/sdk/issues/61894 Change-Id: I66cb2d44d5762719b14b51cb139fa0df6b00468f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459420 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.