Sam Rawlins
d337f4b84b
I found one instance of a variable called "packagesFile" and well, I pulled that thread :/ There is a nice functional simplification here: The `_findPackagesFile` function returned a `_PackagesFile` object, which contained both a `Folder parent` and a `File file`. The latter was never referenced, so simplification 1. Also, the reason to have an object that stores both is that this object handled both `.packages` files, whose immediate parent is `parent`, and `package_config.json` files, whose _grandparent_ is `parent`. But with the distinction gone, we don't need this `_PackagesFile` class, and `_findPackagesFile` can instead return the folder, and be renamed `_findFolderWithPackageConfigFile`. Change-Id: Id7cfad02bad16baeebfd8a719a3a92187fec730f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475930 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.