I found one instance of a variable called "packagesFile" and well, I
pulled that thread :/
There is a nice functional simplification here: The `_findPackagesFile`
function returned a `_PackagesFile` object, which contained both a
`Folder parent` and a `File file`. The latter was never referenced, so
simplification 1. Also, the reason to have an object that stores both
is that this object handled both `.packages` files, whose immediate
parent is `parent`, and `package_config.json` files, whose _grandparent_
is `parent`. But with the distinction gone, we don't need this
`_PackagesFile` class, and `_findPackagesFile` can instead return the
folder, and be renamed `_findFolderWithPackageConfigFile`.
Change-Id: Id7cfad02bad16baeebfd8a719a3a92187fec730f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475930
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Sam Rawlins
d337f4b84b