Jens Johansen
cdad90dfb8
Generally the test loads a big dill thats 90+% the same content as the previous load, then verifies it. This CL loads smarter and verifies less. Before this CL, locally, running pkg/frontend_server/test/frontend_server_flutter.dart took real 24m56.080s user 48m42.422s sys 1m2.360s and the suite edition (using 4 shards in isolates) took real 15m9.196s user 53m41.118s sys 1m30.045s With this CL, locally running pkg/frontend_server/test/frontend_server_flutter.dart takes real 5m0.206s user 9m23.933s sys 0m20.984s and the suite edition takes real 3m24.243s user 12m0.069s sys 0m28.131s On the try-bot the runtime seems to have gone from ~40 minutes to ~20 minutes, the "compile flutter tests" step from ~30 minutes to ~10 minutes and the portion of time actually running the dart-code that compiles, loads and verifies, from ~26 minutes to ~7 minutes. Change-Id: I6db225c33e1c0ee817f3880327e720446150ad7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347282 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency