Paul Berry
cd005ecdd4
This change addresses a corner case discovered during internal testing of the fix for https://github.com/dart-lang/language/issues/731 (improved inference for fold etc.): if there is no order dependency forcing us to do a round of horizontal inference between visiting non-closure arguments and closure arguments, then it's important that we *don't* do a round of horizontal inference before visiting the closure, because there is a risk of inferring too narrow a type. The new algorithm includes all the invocation arguments in dependency analysis, and the dependency rules are structured such that non-closure arguments always wind up in stage 1. If there is no dependency between non-closure arguments and closure arguments, then the closure arguments also wind up in stage 1, and no horizontal inference occurs. If there is a dependency, then closure arguments wind up in stage 2 or later, and horizontal inference occurs between stages. Change-Id: Ida0b28da211f63191c9c9c39e6004893617507bf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240442 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency