dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
cbdae14d2f515899bd1a43d2ffb4d4bd4e179eff
sdk/pkg/analysis_server/test
T
History
Ilya Yanok cbdae14d2f Revert "linter: Refactor prefer_collection_literals to use context type more" 
This reverts commit cd8a3370e7.

Reason for revert: lint starts barking at the wrong tree: b/298917960

Original change's description:
> linter: Refactor prefer_collection_literals to use context type more
>
> There is a basic premise in this rule which we cannot satisfy exactly:
> we need to disallow `LinkedHashSet()` unless the context type requires
> the developer to use `LinkedHashSet`. But the context type is long
> gone when the lint rule is run.
>
> This CL adds some logic to try to attempt figuring out the context
> type in the cases where users have filed bugs, but it will never be
> super accurate.
>
> Fixes https://github.com/dart-lang/linter/issues/4736
> Fixes https://github.com/dart-lang/linter/issues/3057
> Fixes https://github.com/dart-lang/linter/issues/1649
> Fixes https://github.com/dart-lang/linter/issues/2795
>
> Change-Id: I3e6c6de81084dca2825488c89830ab3e7ea63186
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323680
> Reviewed-by: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

Change-Id: I980053dd51ffd4447721e0ad7436b07ca704b554
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324021
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
2023-09-04 10:43:54 +00:00
..
analysis
Extension type. Overrides notification.
2023-09-01 20:44:38 +00:00
channel
Implement the legacy protocol for showing messages and URIs to users
2023-03-24 18:10:17 +00:00
client
Convert the completion documentation tests
2023-06-13 00:32:57 +00:00
edit
Extension type. Request based test for rename, a fix for representation field.
2023-09-01 17:53:57 +00:00
integration
Extension type. Tests for type hierarchy.
2023-08-30 21:18:25 +00:00
lsp
Extension type. Workspace symbols.
2023-09-01 19:15:48 +00:00
lsp_over_legacy
[analysis_server] Fix flaky test
2023-08-10 19:01:24 +00:00
mock_packages
refactor TargetKind enum to class
2023-08-28 23:09:27 +00:00
plugin
Extension type. Tests for type hierarchy.
2023-08-30 21:18:25 +00:00
search
Extension type. More tests for search, highlight, navigation.
2023-08-31 19:36:37 +00:00
services
Extension type. Request based test for rename, a fix for representation field.
2023-09-01 17:53:57 +00:00
src
Revert "linter: Refactor prefer_collection_literals to use context type more"
2023-09-04 10:43:54 +00:00
stress
Use utf8.encode() instead of longer const Utf8Encoder.convert()
2023-07-24 09:28:38 +00:00
timing
[analysis_server] Avoid Future-of-implicit-dynamic in tests
2023-03-07 21:12:58 +00:00
tool
[analysis_server] Update LSP generated classes to latest published version of the spec
2023-04-24 15:09:20 +00:00
utilities
Remove signs '=' from autosnapshotting arg.
2023-05-30 16:33:43 +00:00
utils
[analysis_server] Convert more LSP handlers to work over the legacy protocol
2023-08-07 15:27:46 +00:00
abstract_context.dart
[analyzer] Remove all support for strong-mode
2023-08-17 17:07:37 +00:00
abstract_single_unit.dart
Add support for sort imports to BulkFixProcessor, add prefer_generic_function_type_aliases to list of lints for lightweight mode.
2023-08-08 21:10:54 +00:00
analysis_abstract.dart
Remove AbstractAnalysisTest.
2022-04-24 04:25:50 +00:00
analysis_server_base.dart
[analyzer] Remove all support for strong-mode
2023-08-17 17:07:37 +00:00
analysis_server_test.dart
Swapping NoopAnalytics for noop from package:unified_analytics
2023-07-14 19:15:20 +00:00
benchmarks_test.dart
[analysis_server] Allow skipping slow benchmarks with env variable
2023-06-05 16:01:35 +00:00
completion_test_support.dart
[analysis_server] Add type arguments to remaining raw types
2023-03-16 20:37:57 +00:00
completion_test.dart
Remove debug output from analysis_server/ tests.
2023-04-26 19:58:48 +00:00
constants.dart
…
domain_analysis_test.dart
Reland "[analysis_server] Analyze fix data in fix_data folder"
2023-04-25 00:08:54 +00:00
domain_completion_test.dart
+ completion suggestions for pubspec "screenshots"
2023-05-05 16:54:24 +00:00
domain_completion_util.dart
Rename newFile2() to newFile().
2022-04-19 02:59:57 +00:00
domain_diagnostic_test.dart
Stop using main in test code in more places, part 3
2022-05-06 22:34:50 +00:00
domain_execution_test.dart
[analysis_server] remove unneeded new
2023-01-05 03:05:58 +00:00
domain_server_test.dart
[analysis_server] Extract a UserPromptSender to simplify sending prompts to the user
2023-08-23 16:39:33 +00:00
mocks_lsp.dart
[analysis_server] Avoid Future-of-implicit-dynamic in tests
2023-03-07 21:12:58 +00:00
mocks.dart
Make utf8.encode() have Uint8List return type
2023-07-11 08:54:33 +00:00
protocol_server_test.dart
Extension type. Tests for type hierarchy.
2023-08-30 21:18:25 +00:00
protocol_test.dart
…
socket_server_test.dart
Swapping NoopAnalytics for noop from package:unified_analytics
2023-07-14 19:15:20 +00:00
test_all.dart
Verify that 'utf8.encode()' is not used in the analyzer.
2023-07-17 17:28:31 +00:00
verify_error_fix_status_test.dart
If verify_error_fix_status_test fails, output the status file path.
2023-03-31 14:40:47 +00:00
verify_no_solo_test.dart
Restore sync file methods in AnalysisSession.
2022-03-21 23:27:57 +00:00
verify_no_utf8_encode_test.dart
Verify that 'utf8.encode()' is not used in the analyzer.
2023-07-17 17:28:31 +00:00
verify_sorted_test.dart
verify linter source sorting
2023-09-01 17:40:07 +00:00
verify_tests_test.dart
[analysis_server]/[analyzer] Change package_path alias -> path
2023-07-17 16:48:36 +00:00