Ryan Macnak cb59df7acf [vm, ffi] Better handle errors that are not unhandled exceptions during FFI callbacks. ...

Before this change, an error reaching an FFI callback would attempt to execute the normal invocation stub from the beginning in the FFI callback's frame, which quickly crashes. After this change, the runtime recognizes this marker use of the invocation stub and returns to the FFI callback function instead.

TEST=ffi/unwind
Bug: https://github.com/dart-lang/sdk/issues/39487
Change-Id: I477cfcfc236e6cf518ebfe52860ba49e466ebf8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409562
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

2025-02-19 09:40:34 -08:00

..

generator

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

native_assets

[vm/ffi] Allow omitting native types for @Native functions

2024-12-20 02:05:40 -08:00

static_checks

Refactor regression_44985_test.dart

2025-02-13 23:23:30 -08:00

abi_specific_int_incomplete_aot_test.dart

Opt multitests out of formatting in ffi/.

2024-11-19 07:43:30 +00:00

abi_specific_int_incomplete_jit_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

abi_specific_int_test.dart

Revert "[ffi]: Remove pointer elementAt method."

2024-01-22 12:20:48 +00:00

abi_test.dart

…

address_of_array_generated_test.dart

[vm/ffi] address of operator for FFI leaf calls

2024-04-25 10:06:16 +00:00

address_of_cast_test.dart

[vm/ffi] Supporting .address.cast() expression in ffi leaf calls

2024-08-28 06:34:09 +00:00

address_of_generated_shared.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

address_of_shared.dart

[vm/ffi] address of operator for FFI leaf calls

2024-04-25 10:06:16 +00:00

address_of_struct_generated_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

address_of_test.dart

[vm/ffi] address of operator for FFI leaf calls

2024-04-25 10:06:16 +00:00

address_of_typeddata_generated_test.dart

[vm/ffi] address of operator for FFI leaf calls

2024-04-25 10:06:16 +00:00

aliasing_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

all_positive.dart

…

allocator_test.dart

…

analysis_options.yaml

[tests] Remove obsolete Dart 3.0 experiments from FFI tests

2023-06-15 08:25:18 +00:00

async_callback_tests_utils.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

async_void_function_callbacks_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

bool_test.dart

…

c_types_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

callback_tests_utils.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

callback_unwind_error_test.dart

[vm, ffi] Better handle errors that are not unhandled exceptions during FFI callbacks.

2025-02-19 09:40:34 -08:00

calloc_test.dart

…

coordinate_nnbd_workaround.dart

…

coordinate.dart

…

data_not_asan_test.dart

…

data_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

deeply_immutable_c_api_finalizer_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

dl_api_exit_enter_isolate_test.dart

[gardening] Make more robust test for mutator bit stealing mechanism

2025-02-13 01:19:14 -08:00

dylib_close_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

dylib_isolates_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

dylib_open_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

dylib_utils.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

expando_test.dart

…

extension_methods_test.dart

[vm/ffi] Add refWithFinalizer methods to StructPointer and UnionPointer

2024-12-19 14:07:50 -08:00

external_typed_data_finalizer_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

external_typed_data_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

ffi_callback_unique_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

ffi_induce_a_crash_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

ffi_native_test.dart

[vm/ffi] Remove deprecated FfiNative

2023-11-20 13:16:28 +00:00

ffi_test_helpers.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

ffi.status

[vm/ffi] Error on invoking callback from leaf call

2025-02-04 03:36:29 -08:00

finalizer_external_size_accounting_test.dart

…

function_callbacks_leaf_test.dart

[vm/ffi] Error on invoking callback from leaf call

2025-02-04 03:36:29 -08:00

function_callbacks_many_test.dart

[vm] Remove dual mapping of code

2024-01-09 12:36:55 +00:00

function_callbacks_structs_by_value_generated_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_callbacks_structs_by_value_native_callable_generated_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_callbacks_structs_by_value_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_callbacks_subtype_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_callbacks_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_callbacks_varargs_generated_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_callbacks_varargs_native_callable_generated_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_callbacks_very_many_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_struct_by_value_out_of_bounds_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_args_leaf_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_args_native_leaf_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_args_native_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_args_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_compounds_sizeof_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_compounds.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

function_structs_by_value_generated_ret_arg_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_arg_native_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_arg_native_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_arg_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_native_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_native_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_by_value_generated_ret_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_structs_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_generated_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_generated_native_leaf_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_generated_native_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_generated_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_name_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_varargs_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

function_very_many_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

hardfp_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

has_symbol_test.dart

…

inline_array_multi_dimensional_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

inline_array_test.dart

[vm/ffi] Check Array<T extends AbiSpecificInt> bounds [] and []=

2024-01-05 12:35:49 +00:00

inline_array_variable_length_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

invoke_callback_after_suspension_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

isolate_local_function_callbacks_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

msan_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

native_callables_async_structs_by_value_generated_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

native_callables_sync_structs_by_value_generated_test.dart

[vm/ffi] Allow configuring the variable dimension of variable-length arrays

2024-12-09 22:02:56 +00:00

native_effect_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

negative_function_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

pointer_arithmetic_operators_test.dart

[tests/ffi]: Fix failing pointer arithmetic test.

2023-12-18 18:38:05 +00:00

regress_37254_test.dart

…

regress_39044_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_39063_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_39885_test.dart

Revert "[ffi]: Remove pointer elementAt method."

2024-01-22 12:20:48 +00:00

regress_40537_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_43016_test.dart

…

regress_43693_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_45189_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_45198_test.dart

…

regress_45507_test.dart

…

regress_45988_test.dart

…

regress_46004_test.dart

…

regress_46127_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_47594_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_47673_test.dart

…

regress_49402_test.dart

…

regress_49684_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_51315_test.dart

[ffi]: Add extension operator methods(+,-) for pointer arithmetic

2023-12-14 11:42:38 +00:00

regress_51321_test.dart

…

regress_51504_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_51538_2_test.dart

…

regress_51538_3_test.dart

…

regress_51538_test.dart

…

regress_52298_test.dart

[analyzer/ffi] Fix spurious FFI errors

2023-05-08 15:16:05 +00:00

regress_52399_test.dart

[vm/ffi] MSAN instrument StoreIndexedInstr x64

2023-09-19 16:51:30 +00:00

regress_56412_2_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_56412_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_b_261224444_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_flutter79441_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

regress_flutter97301_test.dart

…

regress_jump_to_frame_test.dart

…

sizeof_test.dart

[vm/ffi] Introduce SizedNativeType

2024-01-12 10:13:39 +00:00

snapshot_test.dart

[vm/ffi] Allow Pointer objects to be shared across isolates

2024-02-07 12:48:50 +00:00

stacktrace_regress_37910_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

structs_nested_test.dart

…

structs_nnbd_workaround_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

structs_packed_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

structs_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

structs_typed_data_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

unaligned_test.dart

Opt multitests out of formatting in ffi/.

2024-11-19 07:43:30 +00:00

variance_function_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

very_large_struct.dart

…

vmspecific_callback_unwind_error_through_handle_test.dart

[vm, ffi] Better handle errors that are not unhandled exceptions during FFI callbacks.

2025-02-19 09:40:34 -08:00

vmspecific_deprecated_funcs_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_dynamic_library_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_enable_ffi_test.dart

Opt multitests out of formatting in ffi/.

2024-11-19 07:43:30 +00:00

vmspecific_ffi_native_handles_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_ffi_native_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_function_callbacks_exit_test.dart

Opt multitests out of formatting in ffi/.

2024-11-19 07:43:30 +00:00

vmspecific_function_callbacks_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_function_gc_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_function_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_handle_dynamically_linked_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_handle_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_highmem_32bit_test.dart

Opt multitests out of formatting in ffi/.

2024-11-19 07:43:30 +00:00

vmspecific_leaf_call_test.dart

[vm,ffi] Avoid linking test DLLs to dart.exe

2025-01-07 08:15:39 -08:00

vmspecific_native_finalizer_2_test.dart

…

vmspecific_native_finalizer_deeply_immutable_test.dart

[vm/ffi] Throw on attaching NativeFinalizer to deeply immutable object

2024-03-28 11:24:36 +00:00

vmspecific_native_finalizer_isolate_groups_test.dart

…

vmspecific_native_finalizer_isolates_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_native_finalizer_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_object_gc_test.dart

…

vmspecific_pointer_load_il_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_regress_37100_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_regress_37511_callbacks_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_regress_37511_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00

vmspecific_regress_37780_test.dart

…

vmspecific_regress_51794_test.dart

[vm/ffi] Fix test on Android

2023-04-05 19:51:09 +00:00

vmspecific_send_port_id_test.dart

[ffi] Format tests/ffi/ with new style - automated

2024-12-06 08:37:10 +00:00