ca31648dbb
This change allows the LegacyAnalysisServer to understand when the plugin isolate (if there is one) is analyzing or not. There are a few primary concepts: * The plugin isolate (PluginServer) notifies the analysis server, when analyzing all files in a context collection, and analyzing changed files, that it is analyzing, and later that it isn't. * The NotificationManager tracks whether the plugin isolate is analyzing or not, based on the last status. * The PluginManager tracks whether new plugins are initialized or not. This is determined by the work done by the PluginWatcher. If no plugins are configured, then plugins are declared to be "initialized". Otherwise, the AnalysisServer sets their status to be "initialized" after receiving the first status notification from the plugin isolate. * The LegacyAnalysisServer now uses the additional "are plugins analyzing" signal, held in NotificationManager, and the "are plugins initializing" signal, held in PluginManager, to determine whether to notify the client that analysis is complete. Change-Id: Ie2b6a6048f074d7a26d7d5d07622a17c30fcab96 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405444 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
249 lines
8.7 KiB
Dart
249 lines
8.7 KiB
Dart
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
|
|
import 'package:analysis_server_plugin/plugin.dart';
|
|
import 'package:analysis_server_plugin/registry.dart';
|
|
import 'package:analysis_server_plugin/src/plugin_server.dart';
|
|
import 'package:analyzer_plugin/protocol/protocol_common.dart' as protocol;
|
|
import 'package:analyzer_plugin/protocol/protocol_constants.dart' as protocol;
|
|
import 'package:analyzer_plugin/protocol/protocol_generated.dart' as protocol;
|
|
import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
|
|
import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
|
|
import 'package:async/async.dart';
|
|
import 'package:test/test.dart';
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import 'lint_rules.dart';
|
|
import 'plugin_server_test_base.dart';
|
|
|
|
void main() {
|
|
defineReflectiveTests(PluginServerTest);
|
|
}
|
|
|
|
@reflectiveTest
|
|
class PluginServerTest extends PluginServerTestBase {
|
|
protocol.ContextRoot get contextRoot => protocol.ContextRoot(packagePath, []);
|
|
|
|
String get filePath => join(packagePath, 'lib', 'test.dart');
|
|
|
|
String get packagePath => convertPath('/package1');
|
|
|
|
StreamQueue<protocol.AnalysisErrorsParams> get _analysisErrorsParams {
|
|
return StreamQueue(channel.notifications
|
|
.where((n) => n.event == protocol.ANALYSIS_NOTIFICATION_ERRORS)
|
|
.map((n) => protocol.AnalysisErrorsParams.fromNotification(n))
|
|
.where((p) => p.file == filePath));
|
|
}
|
|
|
|
@override
|
|
Future<void> setUp() async {
|
|
await super.setUp();
|
|
|
|
pluginServer = PluginServer(
|
|
resourceProvider: resourceProvider, plugins: [_NoLiteralsPlugin()]);
|
|
await startPlugin();
|
|
}
|
|
|
|
Future<void> test_handleAnalysisSetContextRoots() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'bool b = false;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
}
|
|
|
|
Future<void> test_handleEditGetFixes() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'bool b = false;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
|
|
var result = await pluginServer.handleEditGetFixes(
|
|
protocol.EditGetFixesParams(filePath, 'bool b = '.length));
|
|
var fixes = result.fixes;
|
|
// We expect 1 fix because neither `IgnoreDiagnosticOnLine` nor
|
|
// `IgnoreDiagnosticInFile` are registered by the plugin.
|
|
// TODO(srawlins): Investigate whether they should be.
|
|
expect(fixes, hasLength(1));
|
|
expect(fixes[0].fixes, hasLength(1));
|
|
}
|
|
|
|
Future<void> test_lintDiagnosticsAreDisabledByDefault() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'double x = 3.14;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
}
|
|
|
|
Future<void> test_lintDiagnosticsCanBeEnabled() async {
|
|
writeAnalysisOptionsWithPlugin({'no_doubles': true});
|
|
newFile(filePath, 'double x = 3.14;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No doubles message');
|
|
}
|
|
|
|
Future<void> test_updateContent_addOverlay() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'int b = 7;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
|
|
await channel.sendRequest(protocol.AnalysisUpdateContentParams(
|
|
{filePath: protocol.AddContentOverlay('bool b = false;')}));
|
|
|
|
params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
}
|
|
|
|
Future<void> test_updateContent_changeOverlay() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'int b = 7;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
|
|
await channel.sendRequest(protocol.AnalysisUpdateContentParams(
|
|
{filePath: protocol.AddContentOverlay('int b = 0;')}));
|
|
|
|
params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
|
|
await channel.sendRequest(protocol.AnalysisUpdateContentParams({
|
|
filePath: protocol.ChangeContentOverlay(
|
|
[protocol.SourceEdit(0, 9, 'bool b = false')])
|
|
}));
|
|
|
|
params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
}
|
|
|
|
Future<void> test_updateContent_removeOverlay() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'bool b = false;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
|
|
await channel.sendRequest(protocol.AnalysisUpdateContentParams(
|
|
{filePath: protocol.AddContentOverlay('int b = 7;')}));
|
|
|
|
params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
|
|
await channel.sendRequest(protocol.AnalysisUpdateContentParams(
|
|
{filePath: protocol.RemoveContentOverlay()}));
|
|
|
|
params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
}
|
|
|
|
Future<void> test_warningDiagnosticsAreEnabledByDefault() async {
|
|
writeAnalysisOptionsWithPlugin();
|
|
newFile(filePath, 'bool b = false;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, hasLength(1));
|
|
_expectAnalysisError(params.errors.single, message: 'No bools message');
|
|
}
|
|
|
|
Future<void> test_warningDiagnosticsCanBeDisabled() async {
|
|
writeAnalysisOptionsWithPlugin({'no_bools': false});
|
|
newFile(filePath, 'bool b = false;');
|
|
await channel
|
|
.sendRequest(protocol.AnalysisSetContextRootsParams([contextRoot]));
|
|
var paramsQueue = _analysisErrorsParams;
|
|
var params = await paramsQueue.next;
|
|
expect(params.errors, isEmpty);
|
|
}
|
|
|
|
void writeAnalysisOptionsWithPlugin(
|
|
[Map<String, bool> diagnosticConfiguration = const {}]) {
|
|
var buffer = StringBuffer('''
|
|
plugins:
|
|
no_literals:
|
|
path: some/path
|
|
diagnostics:
|
|
''');
|
|
for (var MapEntry(key: diagnosticName, value: isEnabled)
|
|
in diagnosticConfiguration.entries) {
|
|
buffer.writeln(' $diagnosticName: $isEnabled');
|
|
}
|
|
newAnalysisOptionsYamlFile(packagePath, buffer.toString());
|
|
}
|
|
|
|
void _expectAnalysisError(protocol.AnalysisError error,
|
|
{required String message}) {
|
|
expect(
|
|
error,
|
|
isA<protocol.AnalysisError>()
|
|
.having((e) => e.severity, 'severity',
|
|
protocol.AnalysisErrorSeverity.INFO)
|
|
.having(
|
|
(e) => e.type, 'type', protocol.AnalysisErrorType.STATIC_WARNING)
|
|
.having((e) => e.message, 'message', message),
|
|
);
|
|
}
|
|
}
|
|
|
|
class _NoLiteralsPlugin extends Plugin {
|
|
@override
|
|
void register(PluginRegistry registry) {
|
|
registry.registerWarningRule(NoBoolsRule());
|
|
registry.registerLintRule(NoDoublesRule());
|
|
registry.registerFixForRule(NoBoolsRule.code, _WrapInQuotes.new);
|
|
}
|
|
}
|
|
|
|
class _WrapInQuotes extends ResolvedCorrectionProducer {
|
|
static const _wrapInQuotesKind =
|
|
FixKind('dart.fix.wrapInQuotes', 50, 'Wrap in quotes');
|
|
|
|
_WrapInQuotes({required super.context});
|
|
|
|
@override
|
|
CorrectionApplicability get applicability =>
|
|
CorrectionApplicability.acrossFiles;
|
|
|
|
@override
|
|
FixKind get fixKind => _wrapInQuotesKind;
|
|
|
|
@override
|
|
Future<void> compute(ChangeBuilder builder) async {
|
|
var literal = node;
|
|
await builder.addDartFileEdit(file, (builder) {
|
|
builder.addSimpleInsertion(literal.offset, "'");
|
|
builder.addSimpleInsertion(literal.end, "'");
|
|
});
|
|
}
|
|
}
|