Alexander Aprelev c688d0c0c3 [frontend] When serializing compiled expression proc, clone type params first. ...

If there are circular references between type parameters and types in the bounds,
currently serialization leaves original type parameters unchanged, which results
in failures to serialize compiled expression procedure.

This CL makes sure to clone all type parameters first, then passes map
with old-to-new type parameters to CloneVisitor.

Bug: https://github.com/dart-lang/sdk/issues/34052
Change-Id: Idf3e6e6e9099f93cdd7e970ab3b21921cdb29178
Reviewed-on: https://dart-review.googlesource.com/75241
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

2018-09-20 14:55:59 +00:00

..

class_capture.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_capture.expression.yaml.expect

…

class_getter.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_getter.expression.yaml.expect

…

class_invalid_static_capture.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_invalid_static_capture.expression.yaml.expect

…

class_invalid_static_getter.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_invalid_static_getter.expression.yaml.expect

…

class_invalid_static_setter.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_invalid_static_setter.expression.yaml.expect

Revert CLs reworking generator class handling of non-lvalues.

2018-07-27 17:18:28 +00:00

class_invalid_static.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_invalid_static.expression.yaml.expect

Fix incorrect handling of NSM forwarders and pull all logic into CFE. (Take 2)

2018-05-15 11:23:32 +00:00

class_method.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_method.expression.yaml.expect

…

class_setter.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_setter.expression.yaml.expect

…

class_static2.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_static2.expression.yaml.expect

Fix incorrect handling of NSM forwarders and pull all logic into CFE. (Take 2)

2018-05-15 11:23:32 +00:00

class_static3.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_static3.expression.yaml.expect

…

class_static.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_static.expression.yaml.expect

…

class_type_param_bound_illegal.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_bound_illegal.expression.yaml.expect

…

class_type_param_bound.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_bound.expression.yaml.expect

…

class_type_param_circular_reference.expression.yaml

[frontend] When serializing compiled expression proc, clone type params first.

2018-09-20 14:55:59 +00:00

class_type_param_circular_reference.expression.yaml.expect

[frontend] When serializing compiled expression proc, clone type params first.

2018-09-20 14:55:59 +00:00

class_type_param_reference_arg_inferred.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference_arg_inferred.expression.yaml.expect

…

class_type_param_reference_arg.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference_arg.expression.yaml.expect

…

class_type_param_reference_ctor_inferred.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference_ctor_inferred.expression.yaml.expect

…

class_type_param_reference_ctor.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference_ctor.expression.yaml.expect

…

class_type_param_reference_var.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference_var.expression.yaml.expect

…

class_type_param_reference.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

class_type_param_reference.expression.yaml.expect

…

core_lib_imported.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

core_lib_imported.expression.yaml.expect

…

core_lib_internal.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

core_lib_internal.expression.yaml.expect

…

eval.dart

…

invalid_type_variable.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

invalid_type_variable.expression.yaml.expect

…

invalid_variable.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

invalid_variable.expression.yaml.expect

…

invalid.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

invalid.expression.yaml.expect

Fix incorrect handling of NSM forwarders and pull all logic into CFE. (Take 2)

2018-05-15 11:23:32 +00:00

lib_ctor.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_ctor.expression.yaml.expect

…

lib_external_ctor.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_external_ctor.expression.yaml.expect

…

lib_nonctor.expression.yaml

CFE support for expression evaluation, refactored.

2018-05-08 11:20:35 +00:00

lib_nonctor.expression.yaml.expect

…

lib_nonreference.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_nonreference.expression.yaml.expect

Fix incorrect handling of NSM forwarders and pull all logic into CFE. (Take 2)

2018-05-15 11:23:32 +00:00

lib_nonshown_ctor.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_nonshown_ctor.expression.yaml.expect

Split TooManyArguments to support quick fixes

2018-08-15 13:24:22 +00:00

lib_reference.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_reference.expression.yaml.expect

…

lib_simple.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

lib_simple.expression.yaml.expect

…

main.dart

[frontend] When serializing compiled expression proc, clone type params first.

2018-09-20 14:55:59 +00:00

missing_variable_types.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

missing_variable_types.expression.yaml.expect

…

noclass.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

noclass.expression.yaml.expect

…

nolib.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

nolib.expression.yaml.expect

CFE support for expression evaluation, refactored.

2018-05-08 11:20:35 +00:00

param_assign.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

param_assign.expression.yaml.expect

…

param_capture.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

param_capture.expression.yaml.expect

…

param_conflict_class.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

param_conflict_class.expression.yaml.expect

…

param_conflict.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

param_conflict.expression.yaml.expect

…

param_method.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

param_method.expression.yaml.expect

…

type_param_bound.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_bound.expression.yaml.expect

[frontend] When serializing compiled expression proc, clone type params first.

2018-09-20 14:55:59 +00:00

type_param_shadow_arg_ctor_inferred.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow_arg_ctor_inferred.expression.yaml.expect

Wrap Let with ShadowSyntheticExpression in wrapInLocatedCompileTimeError().

2018-06-20 15:44:44 +00:00

type_param_shadow_arg_inferred.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow_arg_inferred.expression.yaml.expect

…

type_param_shadow_arg.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow_arg.expression.yaml.expect

…

type_param_shadow_ctor.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow_ctor.expression.yaml.expect

…

type_param_shadow_var.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow_var.expression.yaml.expect

…

type_param_shadow.expression.yaml

Test code for CFE expression compilation.

2018-04-30 15:33:11 +00:00

type_param_shadow.expression.yaml.expect

…