Srujan Gaddam
b42103c9d1
Our maps are string-based and assume there's only one one @Native class with a given name. This isn't true for these four classes, where there are two types with the same name for each one. This then results in us dropping the definition of one of the two types. Since one of the two types is essentially unused, we should choose to drop that one instead for now. Long-term, we should deprecate the unused types or change our conformance handling to handle multiple types with the same name. We could also choose to unify both definitions, but this may lead to either false positives or renames of members being dropped. This allows us to catch uses of the types that are actually used. Change-Id: I9386cad5b014bee60cd72d21cdf0546640138704 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341331 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com>
50 lines
1.4 KiB
Bash
Executable File
50 lines
1.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
|
|
set -x
|
|
|
|
# go.sh [systems]
|
|
#
|
|
# Convenience script to generate systems. Do not call from build steps or tests
|
|
# - call fremontcutbuilder and dartdomgenerator instead. Do not add 'real'
|
|
# functionality here - change the python code instead.
|
|
#
|
|
# I find it essential to generate all the systems so I know if I am breaking
|
|
# other systems. My habit is to run:
|
|
#
|
|
# ./go.sh | tee Q
|
|
#
|
|
# I can inspect file Q if needed.
|
|
#
|
|
# Re-gen all sdk/lib files
|
|
#
|
|
# The following gives a picture of the changes due to 'work'
|
|
#
|
|
# git checkout master # select client without changes
|
|
# ./go.sh
|
|
# mv ../generated ../generated0 # save generated files
|
|
# git checkout work # select client with changes
|
|
# ./go.sh
|
|
# meld ../generated0 ../generated # compare directories with too
|
|
|
|
SYSTEMS="htmldart2js"
|
|
|
|
if [[ "$1" != "" ]] ; then
|
|
if [[ "$1" =~ ^-- ]]; then
|
|
ARG_OPTION="$1"
|
|
fi
|
|
fi
|
|
|
|
reset && \
|
|
vpython3 ./dartdomgenerator.py --systems="$SYSTEMS" --logging=40 --update-dom-metadata --gen-interop "$ARG_OPTION"
|
|
|
|
# Build the platform dill to be used by the bindings emitter.
|
|
cd ../../..
|
|
./tools/build.py -m release compile_dart2js_platform
|
|
cd ./tools/dom/scripts
|
|
|
|
# Calculate, emit, and format the bindings.
|
|
BINDINGS="../web_library_bindings.dart"
|
|
dart --enable-asserts ./web_library_bindings_emitter.dart $BINDINGS
|
|
dart format $BINDINGS
|